Opened 6 months ago

Closed 4 months ago

#26722 closed enhancement (fixed)

py3: work on the sandpile problem

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.7
Component: python3 Keywords:
Cc: tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 6b63e8d (Commits) Commit: 6b63e8deb6cf5bde5e76fa09851f974d50533618
Dependencies: Stopgaps:

Description (last modified by tscrim)

We change the name of the sink vertices in some sandpile constructions.

Change History (11)

comment:1 Changed 6 months ago by chapoton

  • Branch set to u/chapoton/26722
  • Commit set to 8fd6b68531ff343e048a1c96b9183c1a529f26cf

New commits:

​8fd6b68some work on the sandpile problem

comment:2 Changed 5 months ago by chapoton

  • Milestone changed from sage-8.5 to sage-8.7

comment:3 Changed 4 months ago by git

  • Commit changed from 8fd6b68531ff343e048a1c96b9183c1a529f26cf to ae08212e98267377b1fb0b9d8b3c204e0ec198a8

Branch pushed to git repo; I updated commit sha1. New commits:

​ae08212Merge branch 'u/chapoton/26722' in 8.7.B1

comment:4 Changed 4 months ago by chapoton

  • Authors set to Frédéric Chapoton
  • Branch changed from u/chapoton/26722 to public/ticket/26722
  • Commit changed from ae08212e98267377b1fb0b9d8b3c204e0ec198a8 to 6b63e8deb6cf5bde5e76fa09851f974d50533618
  • Dependencies #26630 deleted
  • Status changed from new to needs_review

Here is a fresh tentative

New commits:

​6b63e8dsome work on sandpiles for python3

comment:5 Changed 4 months ago by chapoton

  • Cc tscrim added

green bot, please review

comment:6 Changed 4 months ago by tscrim

  • Description modified (diff)
  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:7 follow-up: Changed 4 months ago by dcoudert

Also OK on py2 and py3 ;) However, instead of using (-1, -1), one could define a variable sink = (-1, -1) for clarity. I will not fight for it.

I noticed that the sandpile code contains a lot of calls to .vertices() and .edges(), including a .vertices()[0]. So multiple improvements are possible. Also, some random graphs generators could be in digraph_generators.py instead of sandpile.py. Other tickets are needed.

comment:8 in reply to: ↑ 7 Changed 4 months ago by tscrim

Replying to dcoudert:

Also OK on py2 and py3 ;) However, instead of using (-1, -1), one could define a variable sink = (-1, -1) for clarity. I will not fight for it.

Followup ticket when the whole module gets a cleaning.

I noticed that the sandpile code contains a lot of calls to .vertices() and .edges(), including a .vertices()[0]. So multiple improvements are possible. Also, some random graphs generators could be in digraph_generators.py instead of sandpile.py. Other tickets are needed.

Yea, it is old code IIRC that has not been really maintained for quite some time.

comment:9 Changed 4 months ago by dcoudert

Let me know if I can help for the next steps. I'm currently blocked in graphs as I'm waiting for the next beta (inclusion of many tickets) and several tickets are waiting for review.

comment:10 Changed 4 months ago by tscrim

I am not able to really contribute code for the near future. The quick-to-medium reviews are all I have time for. :/ Sorry I am not helping more with actual code.

comment:11 Changed 4 months ago by vbraun

  • Branch changed from public/ticket/26722 to 6b63e8deb6cf5bde5e76fa09851f974d50533618
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.