Opened 4 months ago
Closed 4 months ago
#26712 closed enhancement (fixed)
avoid .vertices() in independent_sets.pyx
Reported by:  dcoudert  Owned by:  

Priority:  major  Milestone:  sage8.5 
Component:  graph theory  Keywords:  py3, graph 
Cc:  tscrim, chapoton  Merged in:  
Authors:  David Coudert  Reviewers:  Travis Scrimshaw, Frédéric Chapoton 
Report Upstream:  N/A  Work issues:  
Branch:  3e57992 (Commits)  Commit:  3e579929ffa3384b8bd73ecae7f5326b524fb1dd 
Dependencies:  Stopgaps: 
Description
With #26566, we can now provide a mapping to dense_graph_init
, so we do it. We thus remove the last call to .vertices()
from this file.
We also perform an extra round of PEP8 cleaning.
Change History (11)
comment:1 Changed 4 months ago by
 Branch set to public/26712_independent_sets
 Cc tscrim chapoton added
 Commit set to 0cdd4c912d08853a1a14fecb270084407c7bc38a
 Status changed from new to needs_review
comment:2 Changed 4 months ago by
 Branch changed from public/26712_independent_sets to public/26712_independent_sets_again
 Commit changed from 0cdd4c912d08853a1a14fecb270084407c7bc38a to c519bff0be18d80b005ea50d1161e6524bfce6ab
New commits:
c519bff  trac #26712: give mapping to dense_graph_init

comment:3 Changed 4 months ago by
 Status changed from needs_review to needs_work
comment:4 Changed 4 months ago by
 Branch changed from public/26712_independent_sets_again to public/26712_independent_sets_2
 Commit changed from c519bff0be18d80b005ea50d1161e6524bfce6ab to bcb31c9f54f9f9bc4cb10d6a93c4406533c6bd07
 Status changed from needs_work to needs_review
comment:5 Changed 4 months ago by
 Reviewers set to Travis Scrimshaw
 Status changed from needs_review to needs_work
According to 2 patchbots, there is a change in output order.
comment:6 Changed 4 months ago by
 Commit changed from bcb31c9f54f9f9bc4cb10d6a93c4406533c6bd07 to 3e579929ffa3384b8bd73ecae7f5326b524fb1dd
comment:7 Changed 4 months ago by
This ticket changes the internal mapping vertex to integer in the class IndependentSets
(replace .vertices
with list(G)
). This modifies the output order in some doctests of posets.py
, but the solutions are the same.
I have updated the doctests in posets.py
.
comment:8 Changed 4 months ago by
 Status changed from needs_work to positive_review
comment:9 Changed 4 months ago by
 Status changed from positive_review to needs_review
sorry, wrong button...
comment:10 Changed 4 months ago by
 Reviewers changed from Travis Scrimshaw to Travis Scrimshaw, Frédéric Chapoton
 Status changed from needs_review to positive_review
ok, let it be
comment:11 Changed 4 months ago by
 Branch changed from public/26712_independent_sets_2 to 3e579929ffa3384b8bd73ecae7f5326b524fb1dd
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
trac #26711: further cleaning in graph_coloring.py
trac #26712: give mapping to dense_graph_init