Opened 4 years ago
Closed 4 years ago
#26712 closed enhancement (fixed)
avoid .vertices() in independent_sets.pyx
Reported by:  David Coudert  Owned by:  

Priority:  major  Milestone:  sage8.5 
Component:  graph theory  Keywords:  py3, graph 
Cc:  Travis Scrimshaw, Frédéric Chapoton  Merged in:  
Authors:  David Coudert  Reviewers:  Travis Scrimshaw, Frédéric Chapoton 
Report Upstream:  N/A  Work issues:  
Branch:  3e57992 (Commits, GitHub, GitLab)  Commit:  3e579929ffa3384b8bd73ecae7f5326b524fb1dd 
Dependencies:  Stopgaps: 
Description
With #26566, we can now provide a mapping to dense_graph_init
, so we do it. We thus remove the last call to .vertices()
from this file.
We also perform an extra round of PEP8 cleaning.
Change History (11)
comment:1 Changed 4 years ago by
Branch:  → public/26712_independent_sets 

Cc:  Travis Scrimshaw Frédéric Chapoton added 
Commit:  → 0cdd4c912d08853a1a14fecb270084407c7bc38a 
Status:  new → needs_review 
comment:2 Changed 4 years ago by
Branch:  public/26712_independent_sets → public/26712_independent_sets_again 

Commit:  0cdd4c912d08853a1a14fecb270084407c7bc38a → c519bff0be18d80b005ea50d1161e6524bfce6ab 
New commits:
c519bff  trac #26712: give mapping to dense_graph_init

comment:3 Changed 4 years ago by
Status:  needs_review → needs_work 

comment:4 Changed 4 years ago by
Branch:  public/26712_independent_sets_again → public/26712_independent_sets_2 

Commit:  c519bff0be18d80b005ea50d1161e6524bfce6ab → bcb31c9f54f9f9bc4cb10d6a93c4406533c6bd07 
Status:  needs_work → needs_review 
comment:5 Changed 4 years ago by
Reviewers:  → Travis Scrimshaw 

Status:  needs_review → needs_work 
According to 2 patchbots, there is a change in output order.
comment:6 Changed 4 years ago by
Commit:  bcb31c9f54f9f9bc4cb10d6a93c4406533c6bd07 → 3e579929ffa3384b8bd73ecae7f5326b524fb1dd 

comment:7 Changed 4 years ago by
This ticket changes the internal mapping vertex to integer in the class IndependentSets
(replace .vertices
with list(G)
). This modifies the output order in some doctests of posets.py
, but the solutions are the same.
I have updated the doctests in posets.py
.
comment:8 Changed 4 years ago by
Status:  needs_work → positive_review 

comment:10 Changed 4 years ago by
Reviewers:  Travis Scrimshaw → Travis Scrimshaw, Frédéric Chapoton 

Status:  needs_review → positive_review 
ok, let it be
comment:11 Changed 4 years ago by
Branch:  public/26712_independent_sets_2 → 3e579929ffa3384b8bd73ecae7f5326b524fb1dd 

Resolution:  → fixed 
Status:  positive_review → closed 
Note: See
TracTickets for help on using
tickets.
New commits:
trac #26711: further cleaning in graph_coloring.py
trac #26712: give mapping to dense_graph_init