Opened 4 years ago

Closed 4 years ago

#26711 closed enhancement (fixed)

avoid .vertices() in graph_coloring.py

Reported by: David Coudert Owned by:
Priority: major Milestone: sage-8.5
Component: graph theory Keywords: py3, graph
Cc: Travis Scrimshaw Merged in:
Authors: David Coudert Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 80f42b3 (Commits, GitHub, GitLab) Commit: 80f42b3e44d0752c509a43482b0da99aea43934a
Dependencies: Stopgaps:

Status badges

Description

After #26484, one call to .vertices() was remaining in method edge_coloring. As it is used for the relabeling of a clique, we can safely replace it with list(h).

In this ticket, we also do another round of PEP8 cleaning and improvements of math formula for the html doc.

Change History (7)

comment:1 Changed 4 years ago by David Coudert

Branch: → public/26711_graph_coloring
Cc: Travis Scrimshaw added
Commit: → 3e1f0dee2e30efc099764ae9db1a23eaa65f98ec
Keywords: py3 graph added
Status: new → needs_review

New commits:

​3e1f0detrac #26711: further cleaning in graph_coloring.py

comment:2 Changed 4 years ago by David Coudert

Branch: public/26711_graph_coloring → public/26711_graph_coloring_2
Commit: 3e1f0dee2e30efc099764ae9db1a23eaa65f98ec → 50374e7b98d94610c3025c80aa4b87b78471b33a

I thought I was in a new branch, but my changes were in develop... I need another coffee... Should be OK now.

New commits:

​50374e7trac #26711: more cleaning in graph_coloring.py
Last edited 4 years ago by David Coudert (previous) (diff)

comment:3 Changed 4 years ago by Frédéric Chapoton

Reviewers: → Frédéric Chapoton 
+        sage: sorted(d.keys())

could be just 

+        sage: sorted(d)

Otherwise, positive review.

comment:4 Changed 4 years ago by git

Commit: 50374e7b98d94610c3025c80aa4b87b78471b33a → 80f42b3e44d0752c509a43482b0da99aea43934a

Branch pushed to git repo; I updated commit sha1. New commits:

​53a47e8trac #26711: Merged with 8.5.beta4
​80f42b3#26711: reviewer's comments

comment:5 Changed 4 years ago by David Coudert

I have implemented you comment.

comment:6 Changed 4 years ago by Frédéric Chapoton

Status: needs_review → positive_review

ok, then

comment:7 Changed 4 years ago by Volker Braun

Branch: public/26711_graph_coloring_2 → 80f42b3e44d0752c509a43482b0da99aea43934a
Resolution: → fixed
Status: positive_review → closed
Note: See TracTickets for help on using tickets.