Opened 2 years ago

Closed 2 years ago

#26711 closed enhancement (fixed)

avoid .vertices() in graph_coloring.py

Reported by: dcoudert Owned by:
Priority: major Milestone: sage-8.5
Component: graph theory Keywords: py3, graph
Cc: tscrim Merged in:
Authors: David Coudert Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 80f42b3 (Commits, GitHub, GitLab) Commit: 80f42b3e44d0752c509a43482b0da99aea43934a
Dependencies: Stopgaps:

Status badges

Description

After #26484, one call to .vertices() was remaining in method edge_coloring. As it is used for the relabeling of a clique, we can safely replace it with list(h).

In this ticket, we also do another round of PEP8 cleaning and improvements of math formula for the html doc.

Change History (7)

comment:1 Changed 2 years ago by dcoudert

  • Branch set to public/26711_graph_coloring
  • Cc tscrim added
  • Commit set to 3e1f0dee2e30efc099764ae9db1a23eaa65f98ec
  • Keywords py3 graph added
  • Status changed from new to needs_review

New commits:

​3e1f0detrac #26711: further cleaning in graph_coloring.py

comment:2 Changed 2 years ago by dcoudert

  • Branch changed from public/26711_graph_coloring to public/26711_graph_coloring_2
  • Commit changed from 3e1f0dee2e30efc099764ae9db1a23eaa65f98ec to 50374e7b98d94610c3025c80aa4b87b78471b33a

I thought I was in a new branch, but my changes were in develop... I need another coffee... Should be OK now.

New commits:

​50374e7trac #26711: more cleaning in graph_coloring.py
Last edited 2 years ago by dcoudert (previous) (diff)

comment:3 Changed 2 years ago by chapoton

  • Reviewers set to Frédéric Chapoton 
+        sage: sorted(d.keys())

could be just 

+        sage: sorted(d)

Otherwise, positive review.

comment:4 Changed 2 years ago by git

  • Commit changed from 50374e7b98d94610c3025c80aa4b87b78471b33a to 80f42b3e44d0752c509a43482b0da99aea43934a

Branch pushed to git repo; I updated commit sha1. New commits:

​53a47e8trac #26711: Merged with 8.5.beta4
​80f42b3#26711: reviewer's comments

comment:5 Changed 2 years ago by dcoudert

I have implemented you comment.

comment:6 Changed 2 years ago by chapoton

  • Status changed from needs_review to positive_review

ok, then

comment:7 Changed 2 years ago by vbraun

  • Branch changed from public/26711_graph_coloring_2 to 80f42b3e44d0752c509a43482b0da99aea43934a
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.