Opened 3 years ago

Closed 3 years ago

#26710 closed defect (fixed)

interact `text_control` should use HTMLMath not HTML

Reported by: klee Owned by:
Priority: minor Milestone: sage-8.7
Component: interact Keywords:
Cc: Merged in:
Authors: Kwankyu Lee Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: ca8ca9b (Commits, GitHub, GitLab) Commit: ca8ca9bf7f0fd4cde0fb70a54d2aba5843b17b41
Dependencies: Stopgaps:

Status badges

Description

text_control in the following does not typeset $A$ in text_control.

@interact
def _(a=text_control("Put a matrix $A$"), b=input_grid(2,2, default=[[1,2],[3,4]], label='')):
    m = matrix(b)
    print(m)

Sage in jupyter use HTML widget to render text_control. The widget HTML does not typeset maths. We should switch to HTMLMath.

By the way, the above example reveals abother defect. label with empty string does not make the label of the input_grid blank, unlike as expected.

Change History (8)

comment:1 Changed 3 years ago by klee

  • Authors set to Kwankyu Lee
  • Branch set to u/klee/26710

comment:2 Changed 3 years ago by git

  • Commit set to ca8ca9bf7f0fd4cde0fb70a54d2aba5843b17b41

Branch pushed to git repo; I updated commit sha1. New commits:

ca8ca9bSwitch from HTML to HTMLMath in text_control

comment:3 Changed 3 years ago by klee

  • Status changed from new to needs_review

comment:4 follow-up: Changed 3 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_review to positive_review

"An HTML" sounds strange to me, but I'm not a native English speaker...

comment:5 in reply to: ↑ 4 Changed 3 years ago by klee

Replying to jdemeyer:

"An HTML" sounds strange to me, but I'm not a native English speaker...

Neither am I, but from StackExchange,

An html but a hyper text... Similarly, an MBA but a Masters of Business....

because "html" begins with a vowel, echh-tee-em-el.

Thanks!

comment:6 Changed 3 years ago by jdemeyer

OK, I thought that "H" was pronounced starting with an "h" sound (more like haitch) but apparently not...

comment:7 Changed 3 years ago by chapoton

  • Milestone changed from sage-8.5 to sage-8.7

comment:8 Changed 3 years ago by vbraun

  • Branch changed from u/klee/26710 to ca8ca9bf7f0fd4cde0fb70a54d2aba5843b17b41
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.