Opened 3 years ago

Closed 3 years ago

#26698 closed enhancement (fixed)

py3: fix some doctests in eta products

Reported by: chapoton Owned by:
Priority: minor Milestone: sage-8.5
Component: python3 Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 3b6f256 (Commits, GitHub, GitLab) Commit: 3b6f256ce685fc51af9813c7988fe0627ef04d34
Dependencies: Stopgaps:

Status badges


Change History (6)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/26698
  • Commit set to 2ee102691a0ec8de2d89c560f4a9e5f1ab20d8b9
  • Status changed from new to needs_review

New commits:

2ee1026py3: fix some doctests in Eta products

comment:2 Changed 3 years ago by tscrim

I think a faster version of the richcmp test would be to first check if op is not < or >, in which case you should do the equality test for the dicts. That way you can avoid creating the temp object and sorting it as much as possible.

comment:3 Changed 3 years ago by git

  • Commit changed from 2ee102691a0ec8de2d89c560f4a9e5f1ab20d8b9 to 3b6f256ce685fc51af9813c7988fe0627ef04d34

Branch pushed to git repo; I updated commit sha1. New commits:

3b6f256trac 26698 more specific richcmp

comment:4 Changed 3 years ago by chapoton

like that ?

comment:5 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

Yes, that will be good. Thank you.

comment:6 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/26698 to 3b6f256ce685fc51af9813c7988fe0627ef04d34
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.