Opened 3 years ago

Closed 3 years ago

#26697 closed enhancement (duplicate)

Py3 : Fix py3 errors in sage.rings.tate_algebra* files

Reported by: vklein Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: python3 Keywords:
Cc: embray Merged in:
Authors: Vincent Klein Reviewers:
Report Upstream: N/A Work issues:
Branch: u/vklein/py3___fix_py3_errors_in_sage_rings_tate_algebra__files (Commits, GitHub, GitLab) Commit: 69a17b0453c19edc4c5d25dc5ea39f483ccd6501
Dependencies: Stopgaps:

Status badges

Description

$ sage -t --long src/sage/rings/tate_algebra* 

----------------------------------------------------------------------
sage -t --long src/sage/rings/tate_algebra_element.pyx  # 63 doctests failed
sage -t --long src/sage/rings/tate_algebra_ideal.pyx  # 29 doctests failed
sage -t --long src/sage/rings/tate_algebra.py  # 4 doctests failed
----------------------------------------------------------------------

Only two simple errors cause all the doctests failures "RuntimeError?: dictionary changed size during iteration" and "TypeError?: Expected list, got range". range and items returning iterators instead of list in py3.

Change History (8)

comment:1 follow-up: Changed 3 years ago by chapoton

duplicate !!

comment:2 Changed 3 years ago by vklein

  • Branch set to u/vklein/py3___fix_py3_errors_in_sage_rings_tate_algebra__files

comment:3 Changed 3 years ago by chapoton

  • Commit set to 69a17b0453c19edc4c5d25dc5ea39f483ccd6501

see #26692

New commits:

​69a17b0Trac #26697: Fix tate_algebra files for python3

comment:4 in reply to: ↑ 1 Changed 3 years ago by vklein

Replying to chapoton:

duplicate !!

Ok, i guess i will review #26692 then.

comment:5 Changed 3 years ago by vklein

  • Milestone changed from sage-8.5 to sage-duplicate/invalid/wontfix
  • Status changed from new to needs_review

comment:6 Changed 3 years ago by vklein

  • Status changed from needs_review to positive_review

comment:7 Changed 3 years ago by chapoton

  • Cc embray added; caruso chapoton removed

Erik, would you please close this one ?

comment:8 Changed 3 years ago by embray

  • Resolution set to duplicate
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.