Opened 3 years ago

Closed 3 years ago

#26688 closed enhancement (fixed)

py3: some fixes in quaternion algebras

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.5
Component: python3 Keywords:
Cc: tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 23b858e (Commits, GitHub, GitLab) Commit: 23b858e472d2b863d924c7e8cf6990de6ac28901
Dependencies: Stopgaps:

Status badges

Description

using bool() in the doctests

and some cleanup of doc

Change History (3)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/26688
  • Cc tscrim added
  • Commit set to 23b858e472d2b863d924c7e8cf6990de6ac28901
  • Status changed from new to needs_review

New commits:

​23b858epy3: some fixes in quaternion algebras

comment:2 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:3 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/26688 to 23b858e472d2b863d924c7e8cf6990de6ac28901
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.