Opened 8 months ago

Closed 8 months ago

Last modified 8 months ago

#26684 closed enhancement (fixed)

py3: fixing round in random graph generator

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.5
Component: python3 Keywords:
Cc: dcoudert Merged in:
Authors: Frédéric Chapoton Reviewers: David Coudert
Report Upstream: N/A Work issues:
Branch: 44f639c (Commits) Commit:
Dependencies: Stopgaps:

Description


Change History (6)

comment:1 Changed 8 months ago by chapoton

  • Branch set to u/chapoton/26684
  • Commit set to 44f639ccd0f6618e98715f86479f56890a935225
  • Status changed from new to needs_review

New commits:

44f639cpy3: fixing round in random graph generator

comment:2 Changed 8 months ago by dcoudert

  • Reviewers set to David Coudert

Why do we need to convert to float before rounding ?

comment:3 Changed 8 months ago by chapoton

because in python3, round calls __round__ which only exists for float. Sigh.

comment:4 Changed 8 months ago by dcoudert

  • Status changed from needs_review to positive_review

Ok... I suspect that in Python4 we will have to declare types :P

LGTM

comment:5 Changed 8 months ago by vbraun

  • Branch changed from u/chapoton/26684 to 44f639ccd0f6618e98715f86479f56890a935225
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:6 Changed 8 months ago by chapoton

  • Commit 44f639ccd0f6618e98715f86479f56890a935225 deleted

EDIT: wrong ticket

Last edited 8 months ago by chapoton (previous) (diff)
Note: See TracTickets for help on using tickets.