Changes between Initial Version and Version 5 of Ticket #26678


Ignore:
Timestamp:
12/04/18 20:15:51 (8 months ago)
Author:
dcoudert
Comment:

I have split this ticket into many smaller and independent tickets. Should be easier to review.

So this ticket becomes a meta-ticket for this group of methods of generic_graph.py.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #26678

    • Property Status changed from new to needs_review
    • Property Type changed from enhancement to task
  • Ticket #26678 – Description

    initial v5  
    1 We clean methods related to
    2 - clustering: `cluster_triangles`, `clustering_average`, `clustering_coeff`, `cluster_transitivity`
    3 - centrality: `centrality_betweenness`, `centrality_closeness`
    4 - paths and distances:  `distance`, `distance_all_pairs`, `eccentricity`, `radius`, `diameter`, `center`, `distance_graph`, `girth`, `periphery`,  `all_paths`, `triangles_count`, `shortest_path`, `shortest_path_length`, `_check_weight_function`, `shortest_paths`, `_path_length`, `shortest_path_lengths`, `shortest_path_all_pairs`, `wiener_index`, `average_distance`, `szeged_index`
     1This ticket concern the cleaning of methods related to clustering, centrality and distances in `generic_graph.py`.
    52
    6 Apart from PEP8 cleaning, the main changes are:
    7 - in `cluster_triangles`, we add parameter `implementation` to use faster methods than networkx. We also remove parameter `with_labels` that was neither documented nor used.
    8 
    9 - in `eccentricity`: add parameter `vertex_list` to method `eccentricity` of `distances_all_pairs.pyx`. This way we save some calls to `.vertices`. We also fix an error in the ordering of returned values (a doctest was false...).
    10 
    11 - `radius`, `center`, `periphery`: replace the long description of the list of algorithm by a forward to method eccentricity
    12 
    13 - avoid using `.vertices` and `.edges` without `sort=False` in all these methods except `eccentricity` that uses the default ordering of `.vertices` when no list of vertices is specified.
     3- #26803  fix bug and clean `szeged_index`
     4- #26813  improve `cluster_triangles` adding parameter `implementation` to use faster methods than networkx. It also removes parameter `with_labels` that was neither documented nor used.
     5- #26814  pep8 in `clustering_average`, `clustering_coeff` and `cluster_transitivity`
     6- #26815  pep8 cleaning in `distances` and `distance_all_pairs`
     7- #26819  improve method `eccentricity` to save calls to `.vertices()`
     8- #26820  pep8 cleaning in `eccentricity`, `center`, `radius`, `diameter`, `periphery`
     9- #26821  pep8 cleaning in `distance_graph` and `girth`
     10- #26822  pep8 cleaning in `centrality_betweenness` and `centrality_closeness`
     11- #26823  pep8 cleaning in methods `all_paths`, `shortest_path`, `shortest_path_length`, `_check_weight_function`, `shortest_paths`, `shortest_path_lengths`, `shortest_path_all_pairs`
     12- #26824  pep8 in `wiener_index` and `average_distance`
     13- #26825  pep8 cleaning in `triangles_count`
     14- #26826  improve method _path_length