#26678 closed task (fixed)

clean generic_graph.py (part 12) - centrality and distances

Reported by: dcoudert Owned by:
Priority: major Milestone: sage-8.5
Component: graph theory Keywords: py3, graph
Cc: tscrim, chapoton Merged in:
Authors: David Coudert Reviewers: David Coudert
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by dcoudert)

This ticket concern the cleaning of methods related to clustering, centrality and distances in generic_graph.py.

  • #26803 fix bug and clean szeged_index
  • #26813 improve cluster_triangles adding parameter implementation to use faster methods than networkx. It also removes parameter with_labels that was neither documented nor used.
  • #26814 pep8 in clustering_average, clustering_coeff and cluster_transitivity
  • #26815 pep8 cleaning in distances and distance_all_pairs
  • #26819 improve method eccentricity to save calls to .vertices()
  • #26820 pep8 cleaning in eccentricity, center, radius, diameter, periphery
  • #26821 pep8 cleaning in distance_graph and girth
  • #26822 pep8 cleaning in centrality_betweenness and centrality_closeness
  • #26823 pep8 cleaning in methods all_paths, shortest_path, shortest_path_length, _check_weight_function, shortest_paths, shortest_path_lengths, shortest_path_all_pairs
  • #26824 pep8 in wiener_index and average_distance
  • #26825 pep8 cleaning in triangles_count
  • #26826 improve method _path_length

Change History (7)

comment:1 Changed 13 months ago by dcoudert

  • Branch set to public/26678_generic_graph_part_12
  • Commit set to ab1746e76145c2078199ff05797ced2ab4040308
  • Status changed from new to needs_review

New commits:

ab1746etrac #26678: generic_graph.py part 12 - distances

comment:2 Changed 13 months ago by git

  • Commit changed from ab1746e76145c2078199ff05797ced2ab4040308 to 8d63ccb23c22c29254d4d7f0a4988df118dacb0b

Branch pushed to git repo; I updated commit sha1. New commits:

8d63ccbtrac #26678: fix issue with docbuild

comment:3 Changed 13 months ago by dcoudert

Now the html doc is build normally.

comment:4 Changed 13 months ago by dcoudert

  • Status changed from needs_review to needs_work

Merge conflict, method szeged_index is now treated in #26803, and this ticket is way too big. Let's split it in different tickets.

comment:5 Changed 13 months ago by dcoudert

  • Branch public/26678_generic_graph_part_12 deleted
  • Commit 8d63ccb23c22c29254d4d7f0a4988df118dacb0b deleted
  • Description modified (diff)
  • Status changed from needs_work to needs_review
  • Type changed from enhancement to task

I have split this ticket into many smaller and independent tickets. Should be easier to review.

So this ticket becomes a meta-ticket for this group of methods of generic_graph.py.

comment:6 Changed 10 months ago by dcoudert

  • Reviewers set to David Coudert
  • Status changed from needs_review to positive_review

All tickets have been positively reviewed. I set this ticket to positive review so we can close it. Thanks to all the reviewers !

comment:7 Changed 10 months ago by vbraun

  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.