Opened 8 months ago

Closed 8 months ago

#26674 closed enhancement (fixed)

py3: fix doctests in weak dict

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.5
Component: python3 Keywords:
Cc: tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 810e6a8 (Commits) Commit: 810e6a8030417a81f400f3c00f5e0087d21ec856
Dependencies: Stopgaps:

Description

where hash should be int

Change History (5)

comment:1 Changed 8 months ago by chapoton

  • Branch set to u/chapoton/26674
  • Commit set to 38b8e5b07c4201920b3042fc19c51df3911ecb02
  • Status changed from new to needs_review

New commits:

9135406improve determinism in Huffman codings
9e3f7bcdifferent algorithm without using heap queues
7c2de4fremove stray line in test
d41dbe2explicitly raise an error when trying to make a Huffman code for fewer than 2 symbols (for which the code in this class breaks)
1c94d3cMerge branch 'u/embray/python3/sage-coding-source_coding-huffman' in 8.5.b2
e913f5dtrac 26026 fix trivial failing doctest
38b8e5bpy3 fix doctests in weak dict

comment:2 Changed 8 months ago by git

  • Commit changed from 38b8e5b07c4201920b3042fc19c51df3911ecb02 to 810e6a8030417a81f400f3c00f5e0087d21ec856

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

810e6a8py3 fix doctests in weak dict

comment:3 Changed 8 months ago by chapoton

  • Cc tscrim added

bot is morally green, please review

comment:4 Changed 8 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:5 Changed 8 months ago by vbraun

  • Branch changed from u/chapoton/26674 to 810e6a8030417a81f400f3c00f5e0087d21ec856
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.