Opened 2 years ago

Closed 2 years ago

#26670 closed enhancement (fixed)

py3: cleanup of toy d basis

Reported by: chapoton Owned by:
Priority: minor Milestone: sage-8.5
Component: python3 Keywords:
Cc: tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 05b18cd (Commits, GitHub, GitLab) Commit: 05b18cd6491c423963ea7c97136ec7b78c4eba3e
Dependencies: Stopgaps:

Status badges

Description

plus full pep cleanup

Change History (5)

comment:1 Changed 2 years ago by chapoton

  • Branch set to u/chapoton/26670
  • Commit set to 05b18cd6491c423963ea7c97136ec7b78c4eba3e
  • Status changed from new to needs_review

New commits:

​05b18cdpy3: cleanup of toy_d_basis (plus pep corrections)

comment:2 Changed 2 years ago by chapoton

bot is morally green.

There is one potentially controversial change, 

     sage: gb = d_basis(I); gb
-    [z - 107196348594952664476180297953816049406949517534824683390654620424703403993052759002989622,
-    y + 84382748470495086324437828161121754084154498572003307352857967748090984550697850484197972764799434672877850291328840,
-    x + 105754645239745824529618668609551113725317621921665293762587811716173,
-    282687803443]
+    [z ..., y ..., x ..., 282687803443]

where the important part of the result is the last integer. The 3 previous linear polynomials are only unique modulo this integer, and random otherwise.

comment:3 Changed 2 years ago by chapoton

  • Cc tscrim added

comment:4 Changed 2 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

I think this change is fine. It shows a little bit more of what is important for that test and makes the test look cleaner.

comment:5 Changed 2 years ago by vbraun

  • Branch changed from u/chapoton/26670 to 05b18cd6491c423963ea7c97136ec7b78c4eba3e
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.