Opened 4 years ago

Closed 4 years ago

#26669 closed defect (fixed)

Error when factoring constant p-adic polynomials

Reported by: pbruin Owned by:
Priority: minor Milestone: sage-8.5
Component: padics Keywords:
Cc: Merged in:
Authors: Peter Bruin Reviewers: Alex J. Best
Report Upstream: N/A Work issues:
Branch: 5bf650c (Commits, GitHub, GitLab) Commit: 5bf650c94bd0538afed8fcf78bb3c91af47f9a37
Dependencies: Stopgaps:

Status badges


In SageMath 8.5.beta2:

sage: R.<x> = Qp(5)[]
sage: R(2).factor()
Traceback (most recent call last):
PrecisionError: p-adic factorization not well-defined since the discriminant is zero up to the requestion p-adic precision

The discriminant is not useful for constant polynomials; we should just return a trivial factorisation.

Change History (4)

comment:1 Changed 4 years ago by pbruin

  • Branch set to u/pbruin/26669-factoring_constant_padic_polynomial
  • Commit set to 5bf650c94bd0538afed8fcf78bb3c91af47f9a37
  • Status changed from new to needs_review

comment:2 Changed 4 years ago by alexjbest

  • Status changed from needs_review to positive_review

This makes sense to me!

comment:3 Changed 4 years ago by alexjbest

  • Reviewers set to Alex J. Best

comment:4 Changed 4 years ago by vbraun

  • Branch changed from u/pbruin/26669-factoring_constant_padic_polynomial to 5bf650c94bd0538afed8fcf78bb3c91af47f9a37
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.