#26667 closed defect (fixed)
distutils no longer shows compiler commands
| Reported by: | jdemeyer | Owned by: | |
|---|---|---|---|
| Priority: | critical | Milestone: | sage-8.5 |
| Component: | build | Keywords: | |
| Cc: | embray, saraedum | Merged in: | |
| Authors: | Jeroen Demeyer | Reviewers: | Julian Rüth, Volker Braun |
| Report Upstream: | N/A | Work issues: | |
| Branch: | c8925d1 (Commits) | Commit: | |
| Dependencies: | Stopgaps: |
Description (last modified by )
Running
touch src/sage/rings/rational.pyx && ./sage -b
shows
Compiling sage/rings/rational.pyx because it changed. [1/1] Cythonizing sage/rings/rational.pyx Executing 1 command (using 1 thread) [1/1] Time to execute 1 command: 0.51 seconds. Total time spent compiling C/C++ extensions: 0.57 seconds.
Note that the compiler invocation (gcc ...) is not shown. This is really annoying for debugging. This got "broken" in #24655.
Change History (15)
comment:1 Changed 13 months ago by
- Summary changed from setuptools no longer shows compiler commands to distutils no longer shows compiler commands
comment:2 Changed 13 months ago by
- Branch set to u/jdemeyer/distutils_no_longer_shows_compiler_commands
comment:3 Changed 13 months ago by
- Cc saraedum added
- Commit set to c8925d1bdc4e29da85efe48f5934389e52634353
comment:4 Changed 13 months ago by
- Status changed from new to needs_review
comment:5 Changed 13 months ago by
- Description modified (diff)
comment:6 Changed 13 months ago by
- Description modified (diff)
comment:7 Changed 13 months ago by
- Reviewers set to Julian Rüth
- Status changed from needs_review to positive_review
Sorry for that.
comment:8 follow-up: ↓ 11 Changed 13 months ago by
- Status changed from positive_review to needs_info
I actually rather like the quieter output. Couldn't we make this an option? When not debugging the extra output is not so helpful or necessary.
comment:9 Changed 13 months ago by
I agree that it's easier to see where the build process is at in the quieter version, and nicer to look at when things work. However, debugging compiler related problems is really hard like this. So, I'd propose to merge this as is, so we can debug again and then improve upon this in a follow-up.
comment:10 Changed 13 months ago by
It would be trivial to just add an option. I'll do it. "Merging" this isn't going to allow anyone to "debug" anything right now anyways since things get "merged" whenever Volker feels like it (if there were GitHub/GitLab? and I could just click "merge" I would agree).
comment:11 in reply to: ↑ 8 Changed 13 months ago by
Too much information is annoying at worst, but missing information is impossible to get after the fact. So when logging, I very much like to err on the side of too much logging.
And an option (with quiet logging by default) is only going to make it more complicated when users ask for help. It's already hard enough to get users send logs, but with Erik's proposal we add an extra hurdle of actually getting the info that we need in the logs.
And I remind that we have the environment variable SAGE_SILENT_BUILD if you don't want to see everything on your stdout. That option still keeps the logs on disk intact.
comment:12 Changed 13 months ago by
- Status changed from needs_info to needs_review
comment:13 Changed 13 months ago by
- Status changed from needs_review to positive_review
You can debate what ends up being printed to the terminal, but whatever you do make sure that the compiler invocation is written to install.log...
comment:14 Changed 13 months ago by
- Branch changed from u/jdemeyer/distutils_no_longer_shows_compiler_commands to c8925d1bdc4e29da85efe48f5934389e52634353
- Resolution set to fixed
- Status changed from positive_review to closed
comment:15 Changed 13 months ago by
- Commit c8925d1bdc4e29da85efe48f5934389e52634353 deleted
- Reviewers changed from Julian Rüth to Julian Rüth, Volker Braun
New commits:
Revert "Silence setup.py"