Opened 2 years ago
Closed 2 years ago
#26663 closed enhancement (fixed)
clean generic_graph.py (part 8) - connectivity
Reported by: | dcoudert | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-8.5 |
Component: | graph theory | Keywords: | py3, graph |
Cc: | tscrim, chapoton | Merged in: | |
Authors: | David Coudert | Reviewers: | Jori Mäntysalo |
Report Upstream: | N/A | Work issues: | |
Branch: | d16117d (Commits, GitHub, GitLab) | Commit: | d16117deafa1da42b22402891e62d11e9e37a48b |
Dependencies: | Stopgaps: |
Description
Here we clean methods related to connectivity: steiner_tree
, edge_disjoint_spanning_trees
, edge_cut
, vertex_cut
, multiway_cut
, max_cut
, longest_path
, hamiltonian_path
, traveling_salesman_problem
, hamiltonian_cycle
, feedback_vertex_set
, flow
, nowhere_zero_flow
, _ford_fulkerson
, multicommodity_flow
, _build_flow_graph
, disjoint_routed_paths
, edge_disjoint_paths
, vertex_disjoint_paths
, and dominating_set
.
- PEP8 cleaning
- avoid using
.vertices
and.edges
whenever possible, or use.edges(sort=False)
in some cases - in method
longest_path
, add akey=...
to asorted
Change History (5)
comment:1 Changed 2 years ago by
- Branch set to public/26663_generic_graph_part_8_connectivity
- Cc tscrim chapoton added
- Commit set to d16117deafa1da42b22402891e62d11e9e37a48b
- Status changed from new to needs_review
- Summary changed from clean connectivity.pyx (part 8) - connectivity to clean generic_graph.py (part 8) - connectivity
comment:2 Changed 2 years ago by
Tested over 8.5.beta3.
comment:3 Changed 2 years ago by
- Reviewers set to Jori Mäntysalo
- Status changed from needs_review to positive_review
Seems to be OK. Tests passed, can be merged to the newest beta.
comment:4 Changed 2 years ago by
Thank you.
comment:5 Changed 2 years ago by
- Branch changed from public/26663_generic_graph_part_8_connectivity to d16117deafa1da42b22402891e62d11e9e37a48b
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
trac #26663: generic_graph (part 8) - connectivity