#26661 closed enhancement (fixed)

pep cleanup of old integer lists

Reported by: chapoton Owned by:
Priority: trivial Milestone: sage-8.5
Component: combinatorics Keywords:
Cc: tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: c6eb283 (Commits) Commit: c6eb2830c4fc205130d7536027c2befca19e6225
Dependencies: Stopgaps:


with no special reason

Change History (8)

comment:1 Changed 15 months ago by chapoton

  • Branch set to u/chapoton/26661
  • Commit set to 3a928b872644f5426afc112085a21f7f82c68839
  • Status changed from new to needs_review

New commits:

3a928b8pep cleanup of old integer list file.

comment:2 Changed 15 months ago by embray

While you're at it:

  • src/sage/combinat/integer_list_old.py

    diff --git a/src/sage/combinat/integer_list_old.py b/src/sage/combinat/integer_list_old.py
    index 280dec5..e028b38 100644
    a b from sage.misc.stopgap import stopgap 
    4444def first(n, min_length, max_length, floor, ceiling, min_slope, max_slope):
    4545    """
    46     Returns the lexicographically smallest valid composition of `n`
     46    Return the lexicographically smallest valid composition of `n`
    4747    satisfying the conditions.
    4949    .. warning::

Shouldn't this be ``n`` with two backticks? Or does our Sphinx configuration recognize function arguments with the default interpreted text role?

comment:3 Changed 15 months ago by git

  • Commit changed from 3a928b872644f5426afc112085a21f7f82c68839 to c6eb2830c4fc205130d7536027c2befca19e6225

Branch pushed to git repo; I updated commit sha1. New commits:

c6eb283trac 26661 details

comment:4 Changed 15 months ago by chapoton

I have made the suggested changes.

comment:5 Changed 15 months ago by chapoton

Erik ?

comment:6 Changed 14 months ago by chapoton

  • Cc tscrim added

please review

comment:7 Changed 14 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review


comment:8 Changed 14 months ago by vbraun

  • Branch changed from u/chapoton/26661 to c6eb2830c4fc205130d7536027c2befca19e6225
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.