Opened 4 years ago

Closed 4 years ago

#26642 closed defect (fixed)

Errors when copying files ignored

Reported by: jdemeyer Owned by:
Priority: blocker Milestone: sage-8.5
Component: build Keywords:
Cc: embray Merged in:
Authors: Jeroen Demeyer Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 2c2df8d (Commits, GitHub, GitLab) Commit: 2c2df8d2df48ba36537209e5c1cf3608feb24772
Dependencies: Stopgaps:

Status badges

Description

This piece in sage-spkg is wrong:

    # Copy files into $SAGE_LOCAL
    $SAGE_SUDO cp -Rp "$PREFIX/." "$SAGE_LOCAL"
    rm -rf "$SAGE_DESTDIR"
    if [ $? -ne 0 ]; then
        error_msg "Error copying files for $PKG_NAME."
        exit 1
    fi

This is checking for errors from rm -rf instead of from the copy operation.

Change History (4)

comment:1 Changed 4 years ago by jdemeyer

  • Branch set to u/jdemeyer/errors_when_copying_files_ignored

comment:2 Changed 4 years ago by jdemeyer

  • Commit set to 2c2df8d2df48ba36537209e5c1cf3608feb24772
  • Status changed from new to needs_review

New commits:

2c2df8dProperly check errors when copying files

comment:3 Changed 4 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, looks good

comment:4 Changed 4 years ago by vbraun

  • Branch changed from u/jdemeyer/errors_when_copying_files_ignored to 2c2df8d2df48ba36537209e5c1cf3608feb24772
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.