Opened 4 years ago

Closed 4 years ago

#26637 closed enhancement (fixed)

clean generic_graph.py (part 6)

Reported by: David Coudert Owned by:
Priority: major Milestone: sage-8.5
Component: graph theory Keywords: py3, graph
Cc: Travis Scrimshaw, Frédéric Chapoton, Sébastien Labbé Merged in:
Authors: David Coudert Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 7766d8e (Commits, GitHub, GitLab) Commit: 7766d8eda5b96821accb2470cd36b85257815204
Dependencies: Stopgaps:

Status badges

Description

Done here:

  • correct method eulerian_orientation for graphs without edge (was not using the right set of vertices)
    • Should we move this method to orientation.py ?
  • some care in min_spanning_tree, but we have remaining issues:
    • algorithm "Prim_fringe" compare vertex labels. I added hash(..) around, but this is certainly not enough.
    • the output of min spanning tree methods is sorted. As said in #26547, there is no reason for that.
  • avoid a call to .edges in cycle_basis

Change History (5)

comment:1 Changed 4 years ago by David Coudert

Branch: public/26637_generic_graph_part_6
Cc: Travis Scrimshaw Frédéric Chapoton Sébastien Labbé added
Commit: 7766d8eda5b96821accb2470cd36b85257815204
Status: newneeds_review

New commits:

7766d8etrac #26637: part 6

comment:2 Changed 4 years ago by Travis Scrimshaw

Reviewers: Travis Scrimshaw
Status: needs_reviewpositive_review

LGTM.

comment:3 Changed 4 years ago by John Palmieri

Is there a metaticket for files in graphs? I'm particularly interested in more on generic_graph.py, especially is_isomorphic, and also base/sparse_graph.pyx, especially iterator_edges. Both of these try to sort vertices, which cause Python 3 doctest failures in homology/simplicial_complexes.py and homology/examples.py.

comment:4 Changed 4 years ago by David Coudert

Let us use #26640 as meta ticket. Should have been opened earlier. Feel free to modify it as I don't know how to organize it.

comment:5 Changed 4 years ago by Volker Braun

Branch: public/26637_generic_graph_part_67766d8eda5b96821accb2470cd36b85257815204
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.