#26637 closed enhancement (fixed)

clean generic_graph.py (part 6)

Reported by: dcoudert Owned by:
Priority: major Milestone: sage-8.5
Component: graph theory Keywords: py3, graph
Cc: tscrim, chapoton, slabbe Merged in:
Authors: David Coudert Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 7766d8e (Commits) Commit: 7766d8eda5b96821accb2470cd36b85257815204
Dependencies: Stopgaps:

Description

Done here:

  • correct method eulerian_orientation for graphs without edge (was not using the right set of vertices)
    • Should we move this method to orientation.py ?
  • some care in min_spanning_tree, but we have remaining issues:
    • algorithm "Prim_fringe" compare vertex labels. I added hash(..) around, but this is certainly not enough.
    • the output of min spanning tree methods is sorted. As said in #26547, there is no reason for that.
  • avoid a call to .edges in cycle_basis

Change History (5)

comment:1 Changed 11 months ago by dcoudert

  • Branch set to public/26637_generic_graph_part_6
  • Cc tscrim chapoton slabbe added
  • Commit set to 7766d8eda5b96821accb2470cd36b85257815204
  • Status changed from new to needs_review

New commits:

7766d8etrac #26637: part 6

comment:2 Changed 11 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:3 Changed 11 months ago by jhpalmieri

Is there a metaticket for files in graphs? I'm particularly interested in more on generic_graph.py, especially is_isomorphic, and also base/sparse_graph.pyx, especially iterator_edges. Both of these try to sort vertices, which cause Python 3 doctest failures in homology/simplicial_complexes.py and homology/examples.py.

comment:4 Changed 11 months ago by dcoudert

Let us use #26640 as meta ticket. Should have been opened earlier. Feel free to modify it as I don't know how to organize it.

comment:5 Changed 10 months ago by vbraun

  • Branch changed from public/26637_generic_graph_part_6 to 7766d8eda5b96821accb2470cd36b85257815204
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.