Opened 4 years ago
Closed 4 years ago
#26637 closed enhancement (fixed)
clean generic_graph.py (part 6)
Reported by: | David Coudert | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-8.5 |
Component: | graph theory | Keywords: | py3, graph |
Cc: | Travis Scrimshaw, Frédéric Chapoton, Sébastien Labbé | Merged in: | |
Authors: | David Coudert | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | 7766d8e (Commits, GitHub, GitLab) | Commit: | 7766d8eda5b96821accb2470cd36b85257815204 |
Dependencies: | Stopgaps: |
Description
Done here:
- correct method
eulerian_orientation
for graphs without edge (was not using the right set of vertices)- Should we move this method to
orientation.py
?
- Should we move this method to
- some care in
min_spanning_tree
, but we have remaining issues:- algorithm
"Prim_fringe"
compare vertex labels. I addedhash(..)
around, but this is certainly not enough. - the output of min spanning tree methods is sorted. As said in #26547, there is no reason for that.
- algorithm
- avoid a call to .edges in
cycle_basis
Change History (5)
comment:1 Changed 4 years ago by
Branch: | → public/26637_generic_graph_part_6 |
---|---|
Cc: | Travis Scrimshaw Frédéric Chapoton Sébastien Labbé added |
Commit: | → 7766d8eda5b96821accb2470cd36b85257815204 |
Status: | new → needs_review |
comment:2 Changed 4 years ago by
Reviewers: | → Travis Scrimshaw |
---|---|
Status: | needs_review → positive_review |
LGTM.
comment:3 Changed 4 years ago by
Is there a metaticket for files in graphs
? I'm particularly interested in more on generic_graph.py
, especially is_isomorphic
, and also base/sparse_graph.pyx
, especially iterator_edges
. Both of these try to sort vertices, which cause Python 3 doctest failures in homology/simplicial_complexes.py
and homology/examples.py
.
comment:4 Changed 4 years ago by
Let us use #26640 as meta ticket. Should have been opened earlier. Feel free to modify it as I don't know how to organize it.
comment:5 Changed 4 years ago by
Branch: | public/26637_generic_graph_part_6 → 7766d8eda5b96821accb2470cd36b85257815204 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
New commits:
trac #26637: part 6