Opened 4 years ago

Closed 4 years ago

#26636 closed enhancement (fixed)

py3: fix doctests in geometry/cone

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.5
Component: python3 Keywords:
Cc: mjo, novoselt Merged in:
Authors: Frédéric Chapoton Reviewers: Andrey Novoseltsev
Report Upstream: N/A Work issues:
Branch: 65f4f7b (Commits, GitHub, GitLab) Commit: 65f4f7b57bf60bc576af77ac49ccc469d6774c56
Dependencies: Stopgaps:

Status badges

Description

by sorting

Change History (5)

comment:1 Changed 4 years ago by chapoton

Branch: u/chapoton/26636
Commit: 65f4f7b57bf60bc576af77ac49ccc469d6774c56
Status: newneeds_review

New commits:

65f4f7bpy3: fix doctests in geometry/cone

comment:2 Changed 4 years ago by mjo

Cc: mjo novoselt added

comment:3 Changed 4 years ago by mjo

For what it's worth, I believe the non-determinism is due to the following in semigroup_generators:

    gens = set()
    for cone in subcones:
        gens.update(cone.semigroup_generators())
    return tuple(gens)

An ordered tuple or PointCollection? (which amounts to the same thing) is always returned, but using set() to eliminate the duplicates makes the order of the tuple itself unreliable.

Andrey will know whether this should be fixed by sorting the output, or by making the output deterministic.

comment:4 Changed 4 years ago by novoselt

Reviewers: Andrey Novoseltsev
Status: needs_reviewpositive_review

Only sorting the output - there is no canonical ordering, so there is no point in wasting time on sorting it always.

comment:5 Changed 4 years ago by vbraun

Branch: u/chapoton/2663665f4f7b57bf60bc576af77ac49ccc469d6774c56
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.