Opened 4 years ago

Closed 4 years ago

#26633 closed enhancement (fixed)

clean (part 4)

Reported by: David Coudert Owned by:
Priority: major Milestone: sage-8.5
Component: graph theory Keywords: py3, graph
Cc: Travis Scrimshaw, Frédéric Chapoton Merged in:
Authors: David Coudert Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 5ba3d3f (Commits, GitHub, GitLab) Commit: 5ba3d3f099d2a6464aaccfcc20e1e57dce776e60
Dependencies: Stopgaps:

Status badges


Done here:

  • add a warning in method allow_multiple_edges as it may compare edge labels of different types in Python 3.
  • reduce the number of sorting in multiple_edges
  • modify a doctest in method kruskal of spanning_tree.pyx that was impacted by changes in methods about multiple edges.
  • various PEP8 cleaning

Change History (5)

comment:1 Changed 4 years ago by David Coudert

Branch: public/26633_generic_graph_part_4
Cc: Travis Scrimshaw Frédéric Chapoton added
Commit: 5ba3d3f099d2a6464aaccfcc20e1e57dce776e60
Status: newneeds_review

New commits:

5ba3d3ftrac #26633: clean (part 4)

comment:2 Changed 4 years ago by David Coudert

Tested over 8.5.beta3. Let me know if I should rebase it.

comment:3 Changed 4 years ago by Frédéric Chapoton

Reviewers: Frédéric Chapoton
Status: needs_reviewpositive_review

ok, good enough. Thanks.

comment:4 Changed 4 years ago by David Coudert

Thank you.

comment:5 Changed 4 years ago by Volker Braun

Branch: public/26633_generic_graph_part_45ba3d3f099d2a6464aaccfcc20e1e57dce776e60
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.