Opened 3 years ago

Closed 2 years ago

#26633 closed enhancement (fixed)

clean generic_graph.py (part 4)

Reported by: dcoudert Owned by:
Priority: major Milestone: sage-8.5
Component: graph theory Keywords: py3, graph
Cc: tscrim, chapoton Merged in:
Authors: David Coudert Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 5ba3d3f (Commits, GitHub, GitLab) Commit: 5ba3d3f099d2a6464aaccfcc20e1e57dce776e60
Dependencies: Stopgaps:

Status badges

Description

Done here:

  • add a warning in method allow_multiple_edges as it may compare edge labels of different types in Python 3.
  • reduce the number of sorting in multiple_edges
  • modify a doctest in method kruskal of spanning_tree.pyx that was impacted by changes in methods about multiple edges.
  • various PEP8 cleaning

Change History (5)

comment:1 Changed 3 years ago by dcoudert

  • Branch set to public/26633_generic_graph_part_4
  • Cc tscrim chapoton added
  • Commit set to 5ba3d3f099d2a6464aaccfcc20e1e57dce776e60
  • Status changed from new to needs_review

New commits:

​5ba3d3ftrac #26633: clean generic_graph.py (part 4)

comment:2 Changed 2 years ago by dcoudert

Tested over 8.5.beta3. Let me know if I should rebase it.

comment:3 Changed 2 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, good enough. Thanks.

comment:4 Changed 2 years ago by dcoudert

Thank you.

comment:5 Changed 2 years ago by vbraun

  • Branch changed from public/26633_generic_graph_part_4 to 5ba3d3f099d2a6464aaccfcc20e1e57dce776e60
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.