Opened 3 years ago

Closed 3 years ago

#26632 closed enhancement (fixed)

improve method distance_matrix

Reported by: dcoudert Owned by:
Priority: major Milestone: sage-8.5
Component: graph theory Keywords: py3, graph
Cc: tscrim, chapoton Merged in:
Authors: David Coudert Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 824f694 (Commits, GitHub, GitLab) Commit: 824f6946c8038c2ec1b74696fbc8a2c45dfde143
Dependencies: Stopgaps:

Status badges

Description

  1. correct the behavior of the method for digraphs. Before, M[i, j] was either the distance from i to j or the distance from j to i. It is now the shortest path distance from i to j.
  2. add parameter vertices to specify the mapping vertices to consecutive integers
  3. allow to specify the parameters of method distance_all_pairs

Change History (5)

comment:1 Changed 3 years ago by dcoudert

  • Branch set to public/26632_distance_matrix
  • Cc tscrim chapoton added
  • Commit set to e0373755391f73f11d33fdacb1577ff2be2ecde1
  • Status changed from new to needs_review

New commits:

​e037375trac #26632: distance_matrix

comment:2 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

it's -> its.

To get the correct links, you probably want :meth:`~sage.graphs.generic_graph.GenericGraph.foo` as GenericGraph is not imported into the global namespace; although since it within that class, I think you can just do :meth:`foo`.

LGTM otherwise and you can set a positive review once fixed.

comment:3 Changed 3 years ago by git

  • Commit changed from e0373755391f73f11d33fdacb1577ff2be2ecde1 to 824f6946c8038c2ec1b74696fbc8a2c45dfde143

Branch pushed to git repo; I updated commit sha1. New commits:

​824f694trac #26632: reviewer's comments

comment:4 Changed 3 years ago by dcoudert

  • Status changed from needs_review to positive_review

Thanks for the review.

For the link, the form :meth:`foo` is working properly. I'm regularly building the html doc to check.

comment:5 Changed 3 years ago by vbraun

  • Branch changed from public/26632_distance_matrix to 824f6946c8038c2ec1b74696fbc8a2c45dfde143
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.