Opened 4 months ago

Closed 3 months ago

#26631 closed enhancement (fixed)

py3 minor fixes in numerical

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.5
Component: python3 Keywords:
Cc: tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 30be374 (Commits) Commit: 30be3745e4e46e91a3744a350be6c0e49adee86f
Dependencies: Stopgaps:

Description


Change History (6)

comment:1 Changed 4 months ago by chapoton

  • Branch set to u/chapoton/26631
  • Commit set to 30be3745e4e46e91a3744a350be6c0e49adee86f
  • Status changed from new to needs_review

New commits:

​30be374py3: minor fixes in numerical/sdp

comment:2 Changed 4 months ago by chapoton

  • Cc tscrim added

bot is morally green, please review

comment:3 Changed 3 months ago by tscrim

  • Reviewers set to Travis Scrimshaw

Don't we want to remove unnecessary keys() here list(x_sol.keys())?

If you don't really care about this nitpick, feel free to set a positive review.

comment:4 Changed 3 months ago by chapoton

  • Status changed from needs_review to positive_review

Hmm, the .keys() here is maybe not so innocent. Trying to remove it got me a MemoryError, so I would prefer not touch that for the moment.

comment:5 Changed 3 months ago by tscrim

Curious. I wouldn't know offhand why that is happening. Thank you for checking.

comment:6 Changed 3 months ago by vbraun

  • Branch changed from u/chapoton/26631 to 30be3745e4e46e91a3744a350be6c0e49adee86f
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.