Opened 2 years ago

Closed 2 years ago

#26630 closed enhancement (fixed)

clean generic_graph.py (part 3)

Reported by: dcoudert Owned by:
Priority: major Milestone: sage-8.5
Component: graph theory Keywords:
Cc: tscrim Merged in:
Authors: David Coudert Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 3d0db40 (Commits) Commit: 3d0db406ac5b4487e2d1ced6bd1fc4e472adbb41
Dependencies: Stopgaps:

Description

Done here:

  • add parameter vertices to specify the mapping vertex to consecutive integers to methods _matrix_, incidence_matrix, weighted_adjacency_matrix. It can also be used from kirchhoff_matrix
  • use it in spanning_trees_count, lex_BFS, spectrum, characteristic_polynomial, eigenvectors, eigenspaces, etc.
  • also do some cleaning in to_dictionary

Change History (6)

comment:1 Changed 2 years ago by dcoudert

  • Branch set to public/26630_generic_graph_part_3
  • Commit set to 731bc96777ef7ca515f7b3d487fd02c45aae56cd
  • Status changed from new to needs_review

New commits:

​731bc96trac #26630: generic_graph.py part 3

comment:2 Changed 2 years ago by git

  • Commit changed from 731bc96777ef7ca515f7b3d487fd02c45aae56cd to 3d0db406ac5b4487e2d1ced6bd1fc4e472adbb41

Branch pushed to git repo; I updated commit sha1. New commits:

​3d0db40trac #26630: fix documentation

comment:3 Changed 2 years ago by dcoudert

I have tested this ticket over 8.5.beta3 and it's working well. Let me know if I should rebase it.

comment:4 Changed 2 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, let it be. By the way, I would prefer tickets without pep8 changes, or only a very small number. Having code changes lost in the middle makes them much more heavy to review.

comment:5 Changed 2 years ago by dcoudert

Thanks for the review.

I agree that I did some too big tickets, and I really thanks you and Travis for your great help in reviewing them. I can certainly split some on them to ease the review if you think it is better. I tried to make tickets by parts / topics of generic_graph.py but this file needs so much work that I don't know how to do it differently.

comment:6 Changed 2 years ago by vbraun

  • Branch changed from public/26630_generic_graph_part_3 to 3d0db406ac5b4487e2d1ced6bd1fc4e472adbb41
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.