#26629 closed enhancement (fixed)

py3: cleanup of cyclic sieving

Reported by: chapoton Owned by:
Priority: minor Milestone: sage-8.5
Component: python3 Keywords:
Cc: tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: df61c43 (Commits) Commit: df61c4318f68e33d05810f7d7f171a470740635c
Dependencies: Stopgaps:

Description


Change History (8)

comment:1 Changed 12 months ago by chapoton

  • Branch set to u/chapoton/26629
  • Commit set to b08416d405bc7d3d1c2fe9beb9be46c1a59a15ab
  • Status changed from new to needs_review

New commits:

b08416dpy3: cleanup of cyclic sieving

comment:2 Changed 12 months ago by git

  • Commit changed from b08416d405bc7d3d1c2fe9beb9be46c1a59a15ab to 72e4d03f0ec8f96836a932dd5901aa8c71847473

Branch pushed to git repo; I updated commit sha1. New commits:

72e4d03detail

comment:3 Changed 12 months ago by chapoton

  • Status changed from needs_review to needs_work

failing doctest :(

comment:4 Changed 12 months ago by git

  • Commit changed from 72e4d03f0ec8f96836a932dd5901aa8c71847473 to df61c4318f68e33d05810f7d7f171a470740635c

Branch pushed to git repo; I updated commit sha1. New commits:

df61c43trac 26629 fix doctest

comment:5 Changed 12 months ago by chapoton

  • Status changed from needs_work to needs_review

may be better now

comment:6 Changed 12 months ago by chapoton

  • Cc tscrim added

green bot, please review

comment:7 Changed 12 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:8 Changed 12 months ago by vbraun

  • Branch changed from u/chapoton/26629 to df61c4318f68e33d05810f7d7f171a470740635c
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.