Opened 3 years ago
Closed 2 years ago
#26625 closed enhancement (fixed)
Update maxima to 5.42.2
Reported by:  arojas  Owned by:  

Priority:  major  Milestone:  sage8.8 
Component:  packages: standard  Keywords:  upgrade, maxima 
Cc:  jdemeyer, fbissey, ghtimokau, saraedum, slelievre  Merged in:  
Authors:  Antonio Rojas  Reviewers:  François Bissey 
Report Upstream:  Reported upstream. No feedback yet.  Work issues:  
Branch:  2530dbf (Commits, GitHub, GitLab)  Commit:  2530dbf2cee43963ae055e3bce354b72ec1b1ce8 
Dependencies:  #12731  Stopgaps: 
Description (last modified by )
Also change the command line argument from r (run in interactive mode) to batchstring (run in batch mode), which is what we want here. The only reason it worked before was a bug in maxima that made r behave like batch mode [1]. This is fixed in 5.42, so using r now makes the maxima interface hang waiting for input.
batchstring also echoes the input, so we need to remove one more line before processing the output.
Tarball: https://vorboss.dl.sourceforge.net/project/maxima/Maximasource/5.42.2source/maxima5.42.2.tar.gz
[1] https://sourceforge.net/p/maxima/mailman/message/36177637/
Change History (27)
comment:1 Changed 3 years ago by
 Branch set to u/arojas/update_maxima_to_5_42_1
comment:2 Changed 3 years ago by
 Commit set to b1dc567be39ef5d67b5b6e588937d803adcff84c
comment:3 Changed 3 years ago by
 Cc jdemeyer fbissey ghtimokau saraedum added
 Component changed from PLEASE CHANGE to packages: standard
 Type changed from PLEASE CHANGE to enhancement
comment:4 Changed 3 years ago by
 Description modified (diff)
comment:5 Changed 3 years ago by
 Commit changed from b1dc567be39ef5d67b5b6e588937d803adcff84c to bda23206074f6a332005c28e6dd6bed03e61fd84
Branch pushed to git repo; I updated commit sha1. New commits:
bda2320  Update one doctest for maxima 5.42

comment:6 Changed 3 years ago by
 Status changed from new to needs_review
comment:7 Changed 3 years ago by
No progress concerning the patch set. That's a bit annoying.
comment:8 Changed 3 years ago by
I am getting
sage t long /usr/lib64/python2.7/sitepackages/sage/symbolic/integration/integral.py ********************************************************************** File "/usr/lib64/python2.7/sitepackages/sage/symbolic/integration/integral.py", line 728, in sage.symbolic.integration.integral.integrate Failed example: integrate(f, x, 0, 2*pi) # long time (4s on sage.math, 2012) Expected: integrate(abs(sin(x)), x, 0, 2*pi) Got: 0 **********************************************************************
comment:9 Changed 3 years ago by
Which is wrong of course.
comment:10 followup: ↓ 11 Changed 3 years ago by
And now that I look at the code in that area I see this is #10914 coming back.
We will not get an evaluated answer here, which is better than the previous (wrong) answer of zero. See :trac:`10914`:: sage: f = abs(sin(x)) sage: integrate(f, x, 0, 2*pi) # long time (4s on sage.math, 2012) integrate(abs(sin(x)), x, 0, 2*pi)
comment:11 in reply to: ↑ 10 Changed 3 years ago by
Replying to fbissey:
And now that I look at the code in that area I see this is #10914 coming back.
We will not get an evaluated answer here, which is better than the previous (wrong) answer of zero. See :trac:`10914`:: sage: f = abs(sin(x)) sage: integrate(f, x, 0, 2*pi) # long time (4s on sage.math, 2012) integrate(abs(sin(x)), x, 0, 2*pi)
Weird, since maxima does give the right answer now
comment:12 Changed 3 years ago by
 Status changed from needs_review to needs_work
comment:13 Changed 3 years ago by
Since I was looking from the sageongentoo perspective there is always the possibility that the maxima maintainer reintroduced a bug (doubtful but possible).
comment:14 Changed 3 years ago by
FWIW this is the commit that breaks it
https://sourceforge.net/p/maxima/code/ci/801a0bb782fd09b9907a599541e1bff622ea453d
I can't decrypt what it means though, or why it breaks this test in sage but not in maxima itself.
comment:15 Changed 3 years ago by
Regarding integrals of abs(sin(x)) and related, see
To explore anything to do with Maxima, it's important to remember
that Sage starts Maxima by setting some defaults including domain : complex
and loading some packages including abs_integrate
, leading to differences
with running Maxima on its own.
See lines 171 to 173 in src/sage/interfaces/maxima_lib.py
init_code = ['besselexpand : true', 'display2d : false', 'domain : complex', 'keepfloat : true', 'load(to_poly_solve)', 'load(simplify_sum)', 'load(abs_integrate)', 'load(diag)']
Bugs in Maxima can be discussed on the maximadiscuss mailing list, always recalling these specifics of running Maxima in Sage.
comment:16 Changed 3 years ago by
Ah indeed, after 'load(abs_integrate)' I can reproduce the issue in maxima
(%i2) load(abs_integrate); (%o2) /usr/share/maxima/5.42.1/share/contrib/integration/abs_integrate.mac (%i3) integrate(abs(sin(x)),x,0,2*%pi); (%o3) 0
comment:17 Changed 3 years ago by
 Report Upstream changed from N/A to Reported upstream. No feedback yet.
Upstream report: https://sourceforge.net/p/maxima/bugs/3519/
comment:18 followup: ↓ 21 Changed 3 years ago by
For reference, Maxima bugs dealing with abs(sin(x)) or abs(cos(x)):
comment:19 Changed 3 years ago by
 Commit changed from bda23206074f6a332005c28e6dd6bed03e61fd84 to 2530dbf2cee43963ae055e3bce354b72ec1b1ce8
comment:20 Changed 3 years ago by
 Description modified (diff)
 Summary changed from Update maxima to 5.42.1 to Update maxima to 5.42.2
comment:21 in reply to: ↑ 18 Changed 3 years ago by
Replying to slelievre:
For reference, Maxima bugs dealing with abs(sin(x)) or abs(cos(x)):
Also for reference, see #12731 and/or the wiki part about abs_integrate problems.
comment:22 Changed 2 years ago by
 Dependencies set to #12731
Adding #12731 as a dependency, since it seems unlikely this will get any attention upstream.
comment:23 Changed 2 years ago by
 Status changed from needs_work to needs_review
comment:24 Changed 2 years ago by
 Cc slelievre added
 Keywords upgrade maxima added
comment:25 Changed 2 years ago by
 Reviewers set to François Bissey
 Status changed from needs_review to positive_review
#12731 is closed so this can go in.
comment:26 Changed 2 years ago by
 Milestone changed from sage8.5 to sage8.8
comment:27 Changed 2 years ago by
 Branch changed from u/arojas/update_maxima_to_5_42_1 to 2530dbf2cee43963ae055e3bce354b72ec1b1ce8
 Resolution set to fixed
 Status changed from positive_review to closed
Branch pushed to git repo; I updated commit sha1. New commits:
Update maxima to 5.42.1