Opened 4 years ago

Closed 4 years ago

#26624 closed enhancement (fixed)

clean generic_graph.py (part 1)

Reported by: David Coudert Owned by:
Priority: major Milestone: sage-8.5
Component: graph theory Keywords: py3, graph
Cc: Travis Scrimshaw, Frédéric Chapoton Merged in:
Authors: David Coudert Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 6879bb6 (Commits, GitHub, GitLab) Commit: 6879bb66040d6d78e68bb8ef6b54d45931fdffed
Dependencies: Stopgaps:

Status badges

Description

Done here:

  • small change in __eq__ to avoid testing twice edge (i, j) if the edge iterator gives edges in random order.
  • remove .vertices() from _bit_vector. This is safe as graph6 and dig6 format only ensure that the string encodes a graph isomorphic to the original graph.
  • some alignments and PEP8.

Change History (3)

comment:1 Changed 4 years ago by David Coudert

Branch: public/26624_generic_graph_part_1
Cc: Travis Scrimshaw Frédéric Chapoton added
Commit: 6879bb66040d6d78e68bb8ef6b54d45931fdffed
Status: newneeds_review

New commits:

6879bb6trac #26624: clean generic_graph.py (part 1)

comment:2 Changed 4 years ago by Frédéric Chapoton

Reviewers: Frédéric Chapoton
Status: needs_reviewpositive_review

ok, then.

comment:3 Changed 4 years ago by Volker Braun

Branch: public/26624_generic_graph_part_16879bb66040d6d78e68bb8ef6b54d45931fdffed
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.