Opened 8 months ago

Closed 7 months ago

#26624 closed enhancement (fixed)

clean generic_graph.py (part 1)

Reported by: dcoudert Owned by:
Priority: major Milestone: sage-8.5
Component: graph theory Keywords: py3, graph
Cc: tscrim, chapoton Merged in:
Authors: David Coudert Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 6879bb6 (Commits) Commit: 6879bb66040d6d78e68bb8ef6b54d45931fdffed
Dependencies: Stopgaps:

Description

Done here:

  • small change in __eq__ to avoid testing twice edge (i, j) if the edge iterator gives edges in random order.
  • remove .vertices() from _bit_vector. This is safe as graph6 and dig6 format only ensure that the string encodes a graph isomorphic to the original graph.
  • some alignments and PEP8.

Change History (3)

comment:1 Changed 8 months ago by dcoudert

  • Branch set to public/26624_generic_graph_part_1
  • Cc tscrim chapoton added
  • Commit set to 6879bb66040d6d78e68bb8ef6b54d45931fdffed
  • Status changed from new to needs_review

New commits:

6879bb6trac #26624: clean generic_graph.py (part 1)

comment:2 Changed 8 months ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, then.

comment:3 Changed 7 months ago by vbraun

  • Branch changed from public/26624_generic_graph_part_1 to 6879bb66040d6d78e68bb8ef6b54d45931fdffed
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.