Opened 2 years ago

Closed 2 years ago

#26610 closed enhancement (fixed)

py3: fix most doctests in combinat/species

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.5
Component: python3 Keywords:
Cc: tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 8c6353a (Commits) Commit: 8c6353a924b9cf95153b17fc1445345e06d5d553
Dependencies: Stopgaps:

Description


Change History (6)

comment:1 Changed 2 years ago by chapoton

  • Branch set to u/chapoton/26610
  • Commit set to dd3721de8b0b8f8b0dbcc0ae882694b2c9c0f97f
  • Status changed from new to needs_review
  • Summary changed from p3: fix most doctests in combinat/species to py3: fix most doctests in combinat/species

New commits:

​dd3721dpy3: fix some doctests in combinat/species

comment:2 Changed 2 years ago by chapoton

  • Cc tscrim added

green bot, please review

comment:3 Changed 2 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

Can you add 2 spaces before (Product of (Combinatorial species) and (Combinatorial species))]. Once done, you can set a positive review on my behalf.

comment:4 Changed 2 years ago by git

  • Commit changed from dd3721de8b0b8f8b0dbcc0ae882694b2c9c0f97f to 8c6353a924b9cf95153b17fc1445345e06d5d553

Branch pushed to git repo; I updated commit sha1. New commits:

​8c6353atrac 26610 reviewer's request

comment:5 Changed 2 years ago by chapoton

  • Status changed from needs_review to positive_review

done, thanks. Setting to positive

comment:6 Changed 2 years ago by vbraun

  • Branch changed from u/chapoton/26610 to 8c6353a924b9cf95153b17fc1445345e06d5d553
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.