Opened 3 years ago

Closed 3 years ago

#26607 closed enhancement (fixed)

small cleanup of the doc of Weyl character ring

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.5
Component: combinatorics Keywords:
Cc: tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 8edca76 (Commits, GitHub, GitLab) Commit: 8edca76f9309e0a22f37c0dfb6fb523dd1bec50d
Dependencies: Stopgaps:

Status badges

Description

mainly cosmetics

also using the category GradedAlgebrasWithBasis

Change History (11)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/26607
  • Cc tscrim added
  • Commit set to 536ced90a472a7ab11f039a7494f304bb2b5c443
  • Status changed from new to needs_review

New commits:

536ced9small cleanup of the doc of Weyl character ring

comment:2 Changed 3 years ago by chapoton

green bot, please review

comment:3 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

Please check that this does not conflict with #26440. Once that is resolved in either direction, you can set a positive review.

comment:4 Changed 3 years ago by chapoton

ok, then this will wait for the next beta.

comment:5 Changed 3 years ago by git

  • Commit changed from 536ced90a472a7ab11f039a7494f304bb2b5c443 to f20245b40e2baf2e779a0f3eb5db9b2025c4ce11

Branch pushed to git repo; I updated commit sha1. New commits:

f20245bMerge branch 'u/chapoton/26607' in 8.5.b2

comment:6 Changed 3 years ago by chapoton

merged, and one small conflict resolved. Let us wait for the patchbot approval.

comment:7 Changed 3 years ago by tscrim

  • Status changed from needs_review to needs_work

The FusionRing is not a graded algebra (at least, by using the dimension of the representation), so when k is not None, we should not add Graded. I can change this and check the category stuff, but I will not be able to do so until either tonight or tomorrow (after I upgrade to beta2).

comment:8 Changed 3 years ago by git

  • Commit changed from f20245b40e2baf2e779a0f3eb5db9b2025c4ce11 to 8edca76f9309e0a22f37c0dfb6fb523dd1bec50d

Branch pushed to git repo; I updated commit sha1. New commits:

8edca76trac 26607 Graded only in some cases

comment:9 Changed 3 years ago by chapoton

  • Status changed from needs_work to needs_review

done.

comment:10 Changed 3 years ago by tscrim

  • Status changed from needs_review to positive_review

Thank you. LGTM and test pass for me.

comment:11 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/26607 to 8edca76f9309e0a22f37c0dfb6fb523dd1bec50d
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.