Opened 4 years ago

Closed 4 years ago

#26601 closed defect (fixed)

py3: make all tests in src/sage/tensor passed

Reported by: mmancini Owned by:
Priority: major Milestone: sage-8.5
Component: geometry Keywords: python3, @parallel, pickle
Cc: egourgoulhon, chapoton, tscrim Merged in:
Authors: Marco Mancini Reviewers: Eric Gourgoulhon
Report Upstream: N/A Work issues:
Branch: 2a481f1 (Commits, GitHub, GitLab) Commit: 2a481f131e50f8a09567f79b0d3e8a9424bdfedd
Dependencies: Stopgaps:

Status badges

Description (last modified by egourgoulhon)

The parallelisation of the function a.__mul__(a) in src/sage/tensor/modules/comp.py was only one test failing with python3 in src/sage/tensor. Previously, with python2.7, to create the partial result we used a list comprehension but now it fails. We have to replace it with a for loop.

Change History (5)

comment:1 Changed 4 years ago by git

  • Commit changed from fbf07a6fe28f4f89c77dbee16b75988e09de051f to 2a481f131e50f8a09567f79b0d3e8a9424bdfedd

Branch pushed to git repo; I updated commit sha1. New commits:

​2a481f1Changed name

comment:2 Changed 4 years ago by egourgoulhon

  • Component changed from PLEASE CHANGE to geometry
  • Description modified (diff)
  • Summary changed from Make all doctests in tensor/modules passed with Python 3 to py3: make all tests in src/sage/tensor passed

comment:3 Changed 4 years ago by mmancini

  • Status changed from new to needs_review

comment:4 Changed 4 years ago by egourgoulhon

  • Cc chapoton tscrim added
  • Reviewers set to Eric Gourgoulhon
  • Status changed from needs_review to positive_review

Thank you Marco!

I've checked the changes with both Python2 and Python3. In particular, with Python3, sage -tp --long src/sage/tensor/ returns now "All tests passed!".

comment:5 Changed 4 years ago by vbraun

  • Branch changed from public/manifolds/To_python3_parellisation_prob_in_tensor_comp to 2a481f131e50f8a09567f79b0d3e8a9424bdfedd
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.