Opened 3 years ago

Closed 3 years ago

#26594 closed enhancement (fixed)

py3: fix round in sha_tate

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.5
Component: python3 Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: David Roe
Report Upstream: N/A Work issues:
Branch: 9650d60 (Commits, GitHub, GitLab) Commit: 9650d60aebc377599a9b62d445c0b259ed7f71df
Dependencies: Stopgaps:

Status badges

Description

plus some doc details

Change History (5)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/26594
  • Status changed from new to needs_review

comment:2 Changed 3 years ago by git

  • Commit set to 9650d60aebc377599a9b62d445c0b259ed7f71df

Branch pushed to git repo; I updated commit sha1. New commits:

​9650d60py3: some fix for round in sha_tate

comment:3 Changed 3 years ago by roed

  • Reviewers set to David Roe

Looks good. The doctest failures look spurious.

comment:4 Changed 3 years ago by roed

  • Status changed from needs_review to positive_review

comment:5 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/26594 to 9650d60aebc377599a9b62d445c0b259ed7f71df
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.