Opened 2 years ago

Closed 2 years ago

#26593 closed defect (fixed)

bug in QQbar comparisons

Reported by: vdelecroix Owned by:
Priority: major Milestone: sage-8.5
Component: number fields Keywords:
Cc: mercatp Merged in:
Authors: Vincent Delecroix Reviewers: David Roe
Report Upstream: N/A Work issues:
Branch: 020f240 (Commits) Commit: 020f2403dae8cbc70704f9f56aead5dbe689225c
Dependencies: Stopgaps:

Description

A strange bug in comparison with equal minimal polynomials (the code took absolute value at a wrong place). Original report on this ​sage-devel thread

Change History (3)

comment:1 Changed 2 years ago by vdelecroix

  • Authors set to Vincent Delecroix
  • Branch set to u/vdelecroix/26593
  • Commit set to 020f2403dae8cbc70704f9f56aead5dbe689225c
  • Status changed from new to needs_review

New commits:

​020f24026593: fix qqbar comparison

comment:2 Changed 2 years ago by roed

  • Reviewers set to David Roe
  • Status changed from needs_review to positive_review

Looks good

comment:3 Changed 2 years ago by vbraun

  • Branch changed from u/vdelecroix/26593 to 020f2403dae8cbc70704f9f56aead5dbe689225c
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.