Opened 3 years ago

Closed 3 years ago

#26590 closed enhancement (fixed)

py3: all tests pass in combinat/words

Reported by: slabbe Owned by:
Priority: major Milestone: sage-8.5
Component: python3 Keywords:
Cc: Merged in:
Authors: Sébastien Labbé Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: c972aaa (Commits, GitHub, GitLab) Commit: c972aaa10c1535e66548f93c71ca632fee7094e5
Dependencies: Stopgaps:

Status badges

Description (last modified by slabbe) 

./sage -btp --long src/sage/combinat/words

Before (with 8.5.beta1): 

----------------------------------------------------------------------
sage -t abstract_word.py  # 1 doctest failed
sage -t morphism.py  # 7 doctests failed
sage -t finite_word.py  # 4 doctests failed
----------------------------------------------------------------------

After (with this branch): 

----------------------------------------------------------------------
All tests passed!
----------------------------------------------------------------------

The failures in finite_word.py were due to #26591.

Change History (4)

comment:1 Changed 3 years ago by slabbe

  • Branch set to u/slabbe/26590
  • Commit set to c972aaa10c1535e66548f93c71ca632fee7094e5
  • Status changed from new to needs_review

New commits:

​c972aaa#26590: py3 all tests passed in combinat/words

comment:2 Changed 3 years ago by slabbe

  • Description modified (diff)

comment:3 Changed 3 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, great. Merci !

comment:4 Changed 3 years ago by vbraun

  • Branch changed from u/slabbe/26590 to c972aaa10c1535e66548f93c71ca632fee7094e5
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.