Opened 4 years ago

Closed 4 years ago

#26581 closed enhancement (fixed)

clean connectivity.pyx (part 1)

Reported by: David Coudert Owned by:
Priority: major Milestone: sage-8.5
Component: graph theory Keywords: py3, graph
Cc: Travis Scrimshaw, Frédéric Chapoton Merged in:
Authors: David Coudert Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 195bdac (Commits, GitHub, GitLab) Commit: 195bdac5acf6fdcaee63d9d7e3bbac929b2c1473
Dependencies: Stopgaps:

Status badges

Description (last modified by David Coudert)

Done in this ticket:

  • add parameter sort to blocks_and_cut_vertices (set to False by default). The default algorithm, Tarjan_Boost don't sort vertices, but the Tarjan_Sage algorithm sorts vertices in each block as well as the list of cut_vertices. We prevent this by default. An alternative is to simply remove the sortings...
  • PEP8 cleaning up to method blocks_and_cuts_tree.

Change History (3)

comment:1 Changed 4 years ago by David Coudert

Branch: public/26581_connectivity_part_1
Cc: Travis Scrimshaw Frédéric Chapoton added
Commit: 195bdac5acf6fdcaee63d9d7e3bbac929b2c1473
Description: modified (diff)
Status: newneeds_review

New commits:

195bdactrac #26581: connectivity part 1

comment:2 Changed 4 years ago by Travis Scrimshaw

Reviewers: Travis Scrimshaw
Status: needs_reviewpositive_review

LGTM.

comment:3 Changed 4 years ago by Volker Braun

Branch: public/26581_connectivity_part_1195bdac5acf6fdcaee63d9d7e3bbac929b2c1473
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.