Opened 4 years ago
Closed 4 years ago
#26578 closed enhancement (fixed)
clean digraph.py
Reported by:  David Coudert  Owned by:  

Priority:  major  Milestone:  sage8.5 
Component:  graph theory  Keywords:  py3, graph 
Cc:  Travis Scrimshaw, Frédéric Chapoton  Merged in:  
Authors:  David Coudert  Reviewers:  Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  e4be7c5 (Commits, GitHub, GitLab)  Commit:  e4be7c54aa140a7a6d7b444dd2b188248b816c0b 
Dependencies:  Stopgaps: 
Description (last modified by )
Mostly PEP8 cleaning and fixing the documentation.
Possible issue: sort lists of vertices in layout_acyclic_dummy
.
Change History (8)
comment:1 Changed 4 years ago by
Branch:  → public/26578_digraph_py 

Cc:  Travis Scrimshaw Frédéric Chapoton added 
Commit:  → 7e257f2d9324a7a534a5088634ee42c03dc6771b 
Description:  modified (diff) 
Status:  new → needs_review 
comment:2 Changed 4 years ago by
This `i` divides `j`.::
will become $i$ divides $j$.:
, so either remove the period or add a space before the ::
.
if weighted is None: self._weighted = False
should be on 2 lines.
Bad space: self.allow_loops(loops ,check=False)
.
Otherwise LGTM.
comment:3 Changed 4 years ago by
Commit:  7e257f2d9324a7a534a5088634ee42c03dc6771b → 9814a1b5bc4ba67c650b2c80217043f4ae0ff700 

Branch pushed to git repo; I updated commit sha1. New commits:
9814a1b  trac #26578: reviewer's comments

comment:4 Changed 4 years ago by
I have implemented your comments. On the way, I found some places where to use .edges(sort=False)
.
comment:5 Changed 4 years ago by
Reviewers:  → Travis Scrimshaw 

Thank you, although you've picked up some trivial failures:
sage t long src/sage/graphs/digraph_generators.py # 4 doctests failed
Once fixed, you can set a positive review.
comment:6 Changed 4 years ago by
Commit:  9814a1b5bc4ba67c650b2c80217043f4ae0ff700 → e4be7c54aa140a7a6d7b444dd2b188248b816c0b 

Branch pushed to git repo; I updated commit sha1. New commits:
e4be7c5  trac #26578: fix doctests in digraph_generators.py

comment:8 Changed 4 years ago by
Branch:  public/26578_digraph_py → e4be7c54aa140a7a6d7b444dd2b188248b816c0b 

Resolution:  → fixed 
Status:  positive_review → closed 
New commits:
clean digraph.py
fix various issues in the documentation