Opened 4 years ago
Closed 4 years ago
#26577 closed enhancement (fixed)
clean graph_backends.pyx
Reported by: | dcoudert | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-8.5 |
Component: | graph theory | Keywords: | py3, graph |
Cc: | tscrim, chapoton | Merged in: | |
Authors: | David Coudert | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | 367fb2c (Commits, GitHub, GitLab) | Commit: | 367fb2ce6b12be622c2b24212e55633bcff2c292 |
Dependencies: | Stopgaps: |
Description
PEP8 cleaning
Change History (6)
comment:1 Changed 4 years ago by
- Branch set to public/26577_graph_backends
- Cc tscrim chapoton added
- Commit set to 5368051aa4ef89ec29b509094c48aa3ca3878978
- Status changed from new to needs_review
comment:2 Changed 4 years ago by
I am not sure I agree with the changes to iterators_*_nbrs
. I generally agree that the notion should be self-explanatory to those that know what I digraph is. I think we should at least have something in those function docs giving a precise definition (although it does not have to be the 1-line description).
In Cython, you can (and should) use dict_obj.iteritems()
rather than iteritems(dict_obj)
as Cython is different than Python.
Nitpick: degree of `v`
is over-indented.
LGTM beyond that.
comment:3 Changed 4 years ago by
- Commit changed from 5368051aa4ef89ec29b509094c48aa3ca3878978 to 367fb2ce6b12be622c2b24212e55633bcff2c292
Branch pushed to git repo; I updated commit sha1. New commits:
367fb2c | trac #26577: reviewer's comments
|
comment:4 Changed 4 years ago by
Thank you for the comments.
comment:5 Changed 4 years ago by
- Reviewers set to Travis Scrimshaw
- Status changed from needs_review to positive_review
Thank you, LGTM.
comment:6 Changed 4 years ago by
- Branch changed from public/26577_graph_backends to 367fb2ce6b12be622c2b24212e55633bcff2c292
- Resolution set to fixed
- Status changed from positive_review to closed
New commits:
trac #26577: graph_backends.pyx