Opened 3 weeks ago

Closed 2 weeks ago

#26576 closed defect (fixed)

py3: Fix issues in sage/rings/padics

Reported by: roed Owned by:
Priority: major Milestone: sage-8.5
Component: python3 Keywords:
Cc: chapoton, caruso Merged in:
Authors: David Roe Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: fb3eefd (Commits) Commit: fb3eefd5182089bf43ddac0f5fe2359fb583b4d4
Dependencies: Stopgaps:

Description


Change History (9)

comment:1 Changed 3 weeks ago by roed

  • Branch set to u/roed/py3lattice

comment:2 Changed 3 weeks ago by git

  • Commit set to f979ca3590b50104eee4534ff660bcda0559d22b

Branch pushed to git repo; I updated commit sha1. New commits:

f979ca3Fix islice problems

comment:3 Changed 3 weeks ago by roed

  • Authors set to David Roe
  • Cc chapoton caruso added
  • Status changed from new to needs_review
  • Summary changed from Make p-adic lattice elements python3 compatible to py3: Fix issues in sage/rings/padics

comment:4 Changed 3 weeks ago by chapoton

islice problems are also fixed in #26573

comment:5 Changed 3 weeks ago by git

  • Commit changed from f979ca3590b50104eee4534ff660bcda0559d22b to 436cdcd28c02f73314e13474b5b81c2bc8281947

Branch pushed to git repo; I updated commit sha1. New commits:

436cdcdRevert islice changes since they're dealt with in another ticket

comment:6 Changed 3 weeks ago by roed

Thanks; I reverted my islice changes.

comment:7 Changed 3 weeks ago by git

  • Commit changed from 436cdcd28c02f73314e13474b5b81c2bc8281947 to fb3eefd5182089bf43ddac0f5fe2359fb583b4d4

Branch pushed to git repo; I updated commit sha1. New commits:

fb3eefdAdd __div__ back into lattice_precision for python2

comment:8 Changed 3 weeks ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok

comment:9 Changed 2 weeks ago by vbraun

  • Branch changed from u/roed/py3lattice to fb3eefd5182089bf43ddac0f5fe2359fb583b4d4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.