#26573 closed enhancement (fixed)

py3: some more care for islice

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.5
Component: python3 Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: David Roe
Report Upstream: N/A Work issues:
Branch: f919fe8 (Commits) Commit: f919fe836bf4604b6ccc37ec6ab789d0ad6335e6
Dependencies: Stopgaps:

Description


Change History (7)

comment:1 Changed 14 months ago by chapoton

  • Branch set to u/chapoton/26573
  • Commit set to aa67c05148338eea20e61d09d4be6f1cf43c6a6e
  • Status changed from new to needs_review

New commits:

aa67c05py3: some more care for islice

comment:2 Changed 14 months ago by chapoton

  • Status changed from needs_review to needs_work

failing doctest

comment:3 Changed 14 months ago by git

  • Commit changed from aa67c05148338eea20e61d09d4be6f1cf43c6a6e to 6abe72243c6944fcd93184971424ab136511a4db

Branch pushed to git repo; I updated commit sha1. New commits:

6abe722trac 26573 undo one change

comment:4 Changed 14 months ago by git

  • Commit changed from 6abe72243c6944fcd93184971424ab136511a4db to f919fe836bf4604b6ccc37ec6ab789d0ad6335e6

Branch pushed to git repo; I updated commit sha1. New commits:

f919fe8trac 26573 fix doctest

comment:5 Changed 14 months ago by chapoton

  • Status changed from needs_work to needs_review

comment:6 Changed 14 months ago by roed

  • Reviewers set to David Roe
  • Status changed from needs_review to positive_review

Looks good

comment:7 Changed 14 months ago by vbraun

  • Branch changed from u/chapoton/26573 to f919fe836bf4604b6ccc37ec6ab789d0ad6335e6
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.