Opened 4 years ago

Closed 4 years ago

#26569 closed enhancement (fixed)

py3: fix manifolds again

Reported by: Frédéric Chapoton Owned by:
Priority: major Milestone: sage-8.5
Component: python3 Keywords:
Cc: Eric Gourgoulhon Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 966209a (Commits, GitHub, GitLab) Commit: 966209a5ebf9e95ea430268ab3913792a799bee0
Dependencies: Stopgaps:

Status badges

Description

after a regression

Change History (4)

comment:1 Changed 4 years ago by Frédéric Chapoton

Branch: → u/chapoton/26569
Cc: Eric Gourgoulhon added
Commit: → 966209a5ebf9e95ea430268ab3913792a799bee0
Status: new → needs_review

New commits:

​966209afix manifolds for python3

comment:2 Changed 4 years ago by Travis Scrimshaw

Reviewers: → Travis Scrimshaw
Status: needs_review → positive_review

LGTM. Sorry I did not catch it before.

comment:3 in reply to:  2 Changed 4 years ago by Eric Gourgoulhon

Replying to tscrim:

LGTM. Sorry I did not catch it before.

Sorry too... (I coreviewed #25936, which introduced the bug). Thanks for the fix.

comment:4 Changed 4 years ago by Volker Braun

Branch: u/chapoton/26569 → 966209a5ebf9e95ea430268ab3913792a799bee0
Resolution: → fixed
Status: positive_review → closed
Note: See TracTickets for help on using tickets.