Opened 3 years ago

Closed 3 years ago

#26569 closed enhancement (fixed)

py3: fix manifolds again

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.5
Component: python3 Keywords:
Cc: egourgoulhon Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 966209a (Commits, GitHub, GitLab) Commit: 966209a5ebf9e95ea430268ab3913792a799bee0
Dependencies: Stopgaps:

Status badges

Description

after a regression

Change History (4)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/26569
  • Cc egourgoulhon added
  • Commit set to 966209a5ebf9e95ea430268ab3913792a799bee0
  • Status changed from new to needs_review

New commits:

​966209afix manifolds for python3

comment:2 follow-up: Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM. Sorry I did not catch it before.

comment:3 in reply to: ↑ 2 Changed 3 years ago by egourgoulhon

Replying to tscrim:

LGTM. Sorry I did not catch it before.

Sorry too... (I coreviewed #25936, which introduced the bug). Thanks for the fix.

comment:4 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/26569 to 966209a5ebf9e95ea430268ab3913792a799bee0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.