Opened 2 years ago

Closed 2 years ago

#26565 closed enhancement (fixed)

clean static_sparse_backend

Reported by: dcoudert Owned by:
Priority: major Milestone: sage-8.5
Component: graph theory Keywords: py3, graph
Cc: tscrim Merged in:
Authors: David Coudert Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 04bdbcc (Commits) Commit: 04bdbcc06cc098c30e746dd52cd0280abb47851b
Dependencies: Stopgaps:

Description

Done in this ticket:

  • move method simple_BFS from static_sparse_backend.pyx to static_sparse_graph.pyx where it should belong. Possible conflict with #26561
  • update accordingly import statements in centrality.pyx and distances_all_pairs.pyx
  • PEP8 cleaning

Change History (4)

comment:1 Changed 2 years ago by dcoudert

  • Branch set to public/26565_static_sparse_backend
  • Cc tscrim added
  • Commit set to 04bdbcc06cc098c30e746dd52cd0280abb47851b
  • Status changed from new to needs_review

New commits:

04bdbcctrac #26565: clean static_sparse_backend

comment:2 Changed 2 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

@dcoudert Can you check for a conflict with #26561? If so, just merge it in. Once checked (and merged if there is a conflict), you can set a positive review.

comment:3 Changed 2 years ago by dcoudert

  • Status changed from needs_review to positive_review

I succeed to merge #26561 with 8.5.beta1 and then #26565 with that without conflict.

Thanks for the review.

comment:4 Changed 2 years ago by vbraun

  • Branch changed from public/26565_static_sparse_backend to 04bdbcc06cc098c30e746dd52cd0280abb47851b
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.