Opened 4 years ago

Closed 4 years ago

#26555 closed enhancement (fixed)

remove a deprecated method in matrix_space

Reported by: Frédéric Chapoton Owned by:
Priority: major Milestone: sage-8.5
Component: linear algebra Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: c6e5dc7 (Commits, GitHub, GitLab) Commit: c6e5dc70fcb27d4d48e3cf0a549c96b66c21b430
Dependencies: Stopgaps:

Status badges

Description

after #15801

plus a few minor doc details

Change History (5)

comment:1 Changed 4 years ago by Frédéric Chapoton

Branch: u/chapoton/26555
Commit: 77767dff4711d6f3305b635c2c307424aa25cdd7
Status: newneeds_review

New commits:

77767dfremove a deprecated method in matrix_space

comment:2 Changed 4 years ago by Travis Scrimshaw

Reviewers: Travis Scrimshaw

LGTM modulo trivial failures in

sage -t --long src/doc/en/thematic_tutorials/coercion_and_categories.rst  # 2 doctests failed

Once fixed, you can set a positive review on my behalf.

comment:3 Changed 4 years ago by git

Commit: 77767dff4711d6f3305b635c2c307424aa25cdd7c6e5dc70fcb27d4d48e3cf0a549c96b66c21b430

Branch pushed to git repo; I updated commit sha1. New commits:

c6e5dc7trac 26555 fixing doctests

comment:4 Changed 4 years ago by Frédéric Chapoton

Status: needs_reviewpositive_review

thanks, done. Setting to positive.

comment:5 Changed 4 years ago by Volker Braun

Branch: u/chapoton/26555c6e5dc70fcb27d4d48e3cf0a549c96b66c21b430
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.