Opened 3 years ago

Closed 2 years ago

#26550 closed enhancement (fixed)

Upgrade to SymPy 1.3

Reported by: slelievre Owned by:
Priority: major Milestone: sage-8.5
Component: packages: standard Keywords: upgrade, sympy
Cc: arojas, fbissey, gh-timokau, jdemeyer, rws, saraedum Merged in:
Authors: François Bissey Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: 8c64ecf (Commits, GitHub, GitLab) Commit: 8c64ecf1d7da1cb137c967b6b52ba307597b7bde
Dependencies: Stopgaps:

Status badges

Description

Sympy 1.3 was released on 2018-09-14.

Our last upgrade was to Sympy 1.2 in #26117.

Change History (7)

comment:1 follow-up: Changed 3 years ago by fbissey

Sadly this release still doesn't include sage's patch defining and using UndefSage. I am guessing it is still necessary.

comment:2 in reply to: ↑ 1 Changed 3 years ago by fbissey

Replying to fbissey:

Sadly this release still doesn't include sage's patch defining and using UndefSage. I am guessing it is still necessary.

And that's the only thing failing if you stick to plain unpatched sympy-1.3

sage -t --long /usr/lib64/python2.7/site-packages/sage/interfaces/sympy.py
**********************************************************************
File "/usr/lib64/python2.7/site-packages/sage/interfaces/sympy.py", line 859, in sage.interfaces.sympy.test_all
Failed example:
    test_all()
Exception raised:
    Traceback (most recent call last):
      File "/usr/lib64/python2.7/site-packages/sage/doctest/forker.py", line 671, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/usr/lib64/python2.7/site-packages/sage/doctest/forker.py", line 1086, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.interfaces.sympy.test_all[1]>", line 1, in <module>
        test_all()
      File "/usr/lib64/python2.7/site-packages/sage/interfaces/sympy.py", line 969, in test_all
        test_undefined_function()
      File "/usr/lib64/python2.7/site-packages/sage/interfaces/sympy.py", line 958, in test_undefined_function
        assert f == sf._sage_()
    TypeError: unbound method _sympysage_function() must be called with f instance as first argument (got nothing instead)
**********************************************************************

which is of course what the patch fixes.

comment:3 Changed 3 years ago by fbissey

  • Authors set to François Bissey
  • Branch set to u/fbissey/sympy-1.3
  • Commit set to 8c64ecf1d7da1cb137c967b6b52ba307597b7bde
  • Status changed from new to needs_review

Ready for review.


New commits:

8c64ecfupdate sympy to 1.3

comment:4 Changed 3 years ago by fbissey

Ping?

comment:5 Changed 3 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer

comment:6 Changed 3 years ago by jdemeyer

  • Status changed from needs_review to positive_review

comment:7 Changed 2 years ago by vbraun

  • Branch changed from u/fbissey/sympy-1.3 to 8c64ecf1d7da1cb137c967b6b52ba307597b7bde
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.