Opened 4 years ago
Closed 4 years ago
#26542 closed enhancement (fixed)
py3: fix some doctests in Cartan types
Reported by: | chapoton | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | sage-8.5 |
Component: | python3 | Keywords: | |
Cc: | Merged in: | ||
Authors: | Frédéric Chapoton | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | 076359b (Commits, GitHub, GitLab) | Commit: | 076359b0bdc405f85b90836be9727d7e3f5f186a |
Dependencies: | Stopgaps: |
Description
Change History (6)
comment:1 Changed 4 years ago by
- Branch set to u/chapoton/26542
- Commit set to b7b7a46aea6410ab5b9adb7c2958ba82b25b13cd
- Status changed from new to needs_review
comment:2 Changed 4 years ago by
- Reviewers set to Travis Scrimshaw
Green patchbot => positive review.
comment:3 Changed 4 years ago by
One failure:
File "src/sage/combinat/root_system/dynkin_diagram.py", line 545, in sage.combinat.root_system.dynkin_diagram.DynkinDiagram_class.relabel Failed example: Dp = D.relabel({-1:4, 0:-3, 1:3, 2:2}); Dp Expected: O---X---O---O 4 -3 3 2 A1|2 relabelled by {0: -3, 1: 3, 2: 2, -1: 4} Got: O---X---O---O 4 -3 3 2 A1|2 relabelled by {-1: 4, 0: -3, 1: 3, 2: 2}
Once fixed, you can set a positive review on my behalf.
comment:4 Changed 4 years ago by
- Commit changed from b7b7a46aea6410ab5b9adb7c2958ba82b25b13cd to 076359b0bdc405f85b90836be9727d7e3f5f186a
Branch pushed to git repo; I updated commit sha1. New commits:
076359b | trac 26542 fix failing doctest
|
comment:5 Changed 4 years ago by
- Status changed from needs_review to positive_review
thanks, done, and setting now to positive
comment:6 Changed 4 years ago by
- Branch changed from u/chapoton/26542 to 076359b0bdc405f85b90836be9727d7e3f5f186a
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
py3: fix some doctests in Cartan types relabeled