Opened 2 years ago

Closed 2 years ago

#26530 closed enhancement (fixed)

cleanup of the category of Coxeter groups

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.5
Component: combinatorics Keywords:
Cc: tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 7e11646 (Commits, GitHub, GitLab) Commit: 7e11646fab0e6a1986c30d95016ff152b3495e6d
Dependencies: Stopgaps:

Status badges

Description

with partial pep8, and fixing the last py3 doctest

Change History (5)

comment:1 Changed 2 years ago by chapoton

  • Branch set to u/chapoton/26530
  • Commit set to 0df92e74a8a1f3dd6e8ff3b865bf9f907529e65e
  • Status changed from new to needs_review

New commits:

​0df92e7cleanup of the category of Coxeter groups

comment:2 Changed 2 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

Nitpick for spaces for index_set (since you are doing PEP8 cleanup on that line): 

def weak_covers(self, side='right', index_set = None, positive=False):

LGTM otherwise and you can set a positive review once changed.

comment:3 Changed 2 years ago by git

  • Commit changed from 0df92e74a8a1f3dd6e8ff3b865bf9f907529e65e to 7e11646fab0e6a1986c30d95016ff152b3495e6d

Branch pushed to git repo; I updated commit sha1. New commits:

​7e11646trac 26530 detail

comment:4 Changed 2 years ago by chapoton

  • Status changed from needs_review to positive_review

done, thanks. Setting to positive

comment:5 Changed 2 years ago by vbraun

  • Branch changed from u/chapoton/26530 to 7e11646fab0e6a1986c30d95016ff152b3495e6d
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.