Opened 2 years ago

Closed 2 years ago

#26529 closed enhancement (fixed)

py3 fix elliptic curve L-series

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.5
Component: python3 Keywords:
Cc: cremona, davidloeffler Merged in:
Authors: Frédéric Chapoton Reviewers: John Cremona
Report Upstream: N/A Work issues:
Branch: 074c02b (Commits, GitHub, GitLab) Commit: 074c02b7b1a3d9d72b7bf12b3bb87c14cb6d1a0f
Dependencies: Stopgaps:

Status badges

Description


Change History (7)

comment:1 Changed 2 years ago by chapoton

  • Branch set to u/chapoton/26529
  • Commit set to b3c52b5e7ca4a7ba8a6e598dfd8cd110d8e77131
  • Status changed from new to needs_review

New commits:

​b3c52b5py3 fix elliptic curve L-series

comment:2 Changed 2 years ago by cremona

Looks good to me. In 

self.__E.conductor().sqrt()

I would change sqrt() to isqrt() perhaps: as it is it will *usually) compute an element of the symbolic ring, while isqrt will give an element of ZZ directly.

comment:3 Changed 2 years ago by git

  • Commit changed from b3c52b5e7ca4a7ba8a6e598dfd8cd110d8e77131 to 074c02b7b1a3d9d72b7bf12b3bb87c14cb6d1a0f

Branch pushed to git repo; I updated commit sha1. New commits:

​074c02btrac 26529 fix

comment:4 follow-up: Changed 2 years ago by chapoton

Done

comment:5 in reply to: ↑ 4 Changed 2 years ago by cremona

  • Reviewers set to John Cremona

Replying to chapoton:

Done

Good! I am happy as soon as light turn green.

comment:6 Changed 2 years ago by chapoton

  • Status changed from needs_review to positive_review

bot is green, setting to positive

comment:7 Changed 2 years ago by vbraun

  • Branch changed from u/chapoton/26529 to 074c02b7b1a3d9d72b7bf12b3bb87c14cb6d1a0f
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.