Opened 4 years ago

Closed 4 years ago

#26527 closed enhancement (fixed)

py3 work on automorphism groups of graphs

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.5
Component: python3 Keywords:
Cc: dcoudert, dimpase, tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: David Coudert
Report Upstream: N/A Work issues:
Branch: 8ba13d0 (Commits, GitHub, GitLab) Commit: 8ba13d04af13fb1978ee04316a4ca0e486bc91cf
Dependencies: Stopgaps:

Status badges

Description

trying not to use .vertices() there

Change History (9)

comment:1 Changed 4 years ago by chapoton

  • Branch set to u/chapoton/26527
  • Commit set to 7e48342efbabfca62af2cee0b0c7e5a30cfacfe1
  • Status changed from new to needs_review

New commits:

​7e48342py3: work on automorphism groups of graphs

comment:2 Changed 4 years ago by dcoudert

  • Cc dima added

I'm adding dima in the loop as I know nothing about permutation groups and this look very different (but it might be ok). 

-            Permutation Group with generators [('01','02')('10','20')('11','22')('12','21'), ('00','11')('01','10')('02','12')('20','21')]
+            Permutation Group with generators [('02','10','21')('00','11','22')('01','12','20'), ('02','01')('10','20')('21','12')('22','11')]

comment:3 Changed 4 years ago by tscrim

They are isomorphic: 

sage: G = PermutationGroup([[('01','02'),('10','20'),('11','22'),('12','21')], [('00','11'),('01','10'),('02','12'),('20','21')]])
sage: H = PermutationGroup([[('02','10','21'),('00','11','22'),('01','12','20')], [('02','01'),('10','20'),('21','12'),('22','11')]])
sage: G
Permutation Group with generators [('01','02')('10','20')('11','22')('12','21'), ('00','11')('01','10')('02','12')('20','21')]
sage: H
Permutation Group with generators [('01','02')('10','20')('11','22')('12','21'), ('00','11','22')('01','12','20')('02','10','21')]
sage: G.is_isomorphic(H)
True

comment:4 Changed 4 years ago by chapoton

  • Status changed from needs_review to needs_work

some failing doctests

comment:5 Changed 4 years ago by git

  • Commit changed from 7e48342efbabfca62af2cee0b0c7e5a30cfacfe1 to 8ba13d04af13fb1978ee04316a4ca0e486bc91cf

Branch pushed to git repo; I updated commit sha1. New commits:

​d060163Merge branch 'u/chapoton/26527' in 8.5.b2
​8ba13d0trac 26527 fix doctests by enhancing matrix rows-columns-automorphisms

comment:6 Changed 4 years ago by chapoton

  • Status changed from needs_work to needs_review

let's try again

comment:7 Changed 4 years ago by chapoton

  • Cc dimpase tscrim added; dima removed

bot is morally green, please review

comment:8 Changed 4 years ago by dcoudert

  • Reviewers set to David Coudert
  • Status changed from needs_review to positive_review

LGTM.

comment:9 Changed 4 years ago by vbraun

  • Branch changed from u/chapoton/26527 to 8ba13d04af13fb1978ee04316a4ca0e486bc91cf
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.