Opened 6 months ago

Closed 2 months ago

#26520 closed task (fixed)

meta-ticket for cleaning graph decompositions

Reported by: dcoudert Owned by:
Priority: major Milestone: sage-8.7
Component: graph theory Keywords: py3, graph
Cc: tscrim, chapoton Merged in:
Authors: David Coudert Reviewers: David Coudert
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by dcoudert)

We improve all files in src/sage/graphs/graph_decompositions/: PEP8, reduce dependency to the ordering given by G.vertices() whenever possible, etc.

See tickets:

  • #26827 avoid .vertices() in bandwidth.pyx
  • #26828 pep8 cleaning of bandwidth.pyx
  • #26829 improve and clean cutwidth.pyx
  • #26830 avoid .vertices() and .edges() in graph_products.pyx
  • #26831 avoid .vertices() in rankwidth.pyx and do pep8 cleaning
  • #26832 avoid using .vertices() in tdlib.pyx
  • #26833 avoid using .vertices() in vertex_separation.pyx
  • #26834 pep8 cleaning in vertex_separation.pyx

Change History (10)

comment:1 Changed 6 months ago by dcoudert

  • Branch set to public/26520_graph_decompositions
  • Commit set to 100374c473980cd1393aa37c7e4ecc0bcec74ef6

New commits:

​49014d6trac #26520: fast_digraph and vertex_separation
​0ddd5e1trac #26520: cutwidth
​741eb71trac #26520: rankwidth
​98210e2trac #26520: bandwidth
​2b4bfc4trac #26520: graph_products
​100374ctrac #26520: tdlib.pyx

comment:2 Changed 6 months ago by dcoudert

  • Description modified (diff)
  • Status changed from new to needs_review

comment:3 Changed 6 months ago by git

  • Commit changed from 100374c473980cd1393aa37c7e4ecc0bcec74ef6 to 0a11a7e2dc495a4ee35cd2e7fe9f353eea055ad1

Branch pushed to git repo; I updated commit sha1. New commits:

​36d8577trac #25620: Merged with 8.5.beta1
​0a11a7etrac #26520: remove import of six

comment:4 Changed 6 months ago by git

  • Commit changed from 0a11a7e2dc495a4ee35cd2e7fe9f353eea055ad1 to 1e3dcb843c99ca3c1b6ed7f983bd8825813b4f61

Branch pushed to git repo; I updated commit sha1. New commits:

​ccbd83btrac #26520: Merged with 8.5.beta2
​1e3dcb8trac #26520: pass vertex_to_int to dense_graph_init

comment:5 Changed 6 months ago by dcoudert

Now gives the mapping to dense_graph_init.

comment:6 Changed 6 months ago by dcoudert

  • Cc tscrim chapoton added

comment:7 Changed 5 months ago by dcoudert

working with 8.5.beta3

comment:8 Changed 5 months ago by dcoudert

  • Branch public/26520_graph_decompositions deleted
  • Commit 1e3dcb843c99ca3c1b6ed7f983bd8825813b4f61 deleted
  • Description modified (diff)
  • Summary changed from clean graph decompositions to meta-ticket for cleaning graph decompositions
  • Type changed from enhancement to task

This ticket was way too big, so I changed it to a meta-ticket and split the work in multiple independent tickets. Should be easier to review that way.

comment:9 Changed 3 months ago by dcoudert

  • Milestone changed from sage-8.5 to sage-8.7
  • Reviewers set to David Coudert
  • Status changed from needs_review to positive_review

All tickets corresponding to this task are now closed. Therefore, I set this ticket to positive review as it can now be closed.

comment:10 Changed 2 months ago by vbraun

  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.