Opened 3 years ago

Closed 3 years ago

#26510 closed enhancement (fixed)

Py3: Fix combinat.subset.py for python3

Reported by: vklein Owned by:
Priority: minor Milestone: sage-8.5
Component: python3 Keywords:
Cc: Merged in:
Authors: Vincent Klein Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 3422739 (Commits, GitHub, GitLab) Commit: 3422739242b994f7291bd6cbe63ef2c095fefc77
Dependencies: Stopgaps:

Status badges

Description

Some small fixes.

Change History (11)

comment:1 Changed 3 years ago by vklein

  • Authors set to Vincent Klein

comment:2 Changed 3 years ago by vklein

  • Branch set to u/vklein/py3__fix_combinat_subset_py_for_python3

comment:3 Changed 3 years ago by vklein

  • Commit set to 71c60abd84eff5fd217fd6f57dc7012631bc3984
  • Status changed from new to needs_review

New commits:

​71c60abTrac #26510: Fix combinat.subset for python3

comment:4 Changed 3 years ago by chapoton

changes about islice will conflict with #26573

comment:5 Changed 3 years ago by vklein

  • Status changed from needs_review to needs_work

Indeed.

comment:6 Changed 3 years ago by git

  • Commit changed from 71c60abd84eff5fd217fd6f57dc7012631bc3984 to 3422739242b994f7291bd6cbe63ef2c095fefc77

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​32ab644Trac #26510: Fix combinat.subset for python3
​3422739Trac #26545: Reverse 'islice' corrections and rebase ...

comment:7 Changed 3 years ago by vklein

  • Status changed from needs_work to needs_review

Rebase on 8.5.b1, "islice" fixes cancelled.

comment:8 Changed 3 years ago by chapoton

  • Reviewers set to Frédéric Chapoton

ok..

comment:9 Changed 3 years ago by chapoton

  • Status changed from needs_review to positive_review

comment:10 Changed 3 years ago by vklein

Merci

comment:11 Changed 3 years ago by vbraun

  • Branch changed from u/vklein/py3__fix_combinat_subset_py_for_python3 to 3422739242b994f7291bd6cbe63ef2c095fefc77
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.