Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#26499 closed defect (fixed)

sagenb 1.1.0

Reported by: Dima Pasechnik Owned by:
Priority: major Milestone: sage-8.5
Component: packages: standard Keywords:
Cc: François Bissey Merged in:
Authors: Dima Pasechnik Reviewers: François Bissey
Report Upstream: N/A Work issues:
Branch: 20b0980 (Commits, GitHub, GitLab) Commit:
Dependencies: #24692, #25382 Stopgaps:

Status badges

Description (last modified by Dima Pasechnik)

a routine update, incorporating most urgent PRs.

Also, in view of #25382

tarball: https://github.com/sagemath/sagenb/releases/download/1.1.0/sagenb-1.1.0.tar.bz2

Change History (22)

comment:1 Changed 4 years ago by Dima Pasechnik

should we also do the downgrade to optional here?

comment:2 Changed 4 years ago by Dima Pasechnik

Status: newneeds_review

comment:3 Changed 4 years ago by Timo Kaufmann

should we also do the downgrade to optional here?

You mean downgrading the spkg to optional? Is that actually possible already?

comment:4 Changed 4 years ago by Dima Pasechnik

Could someone with python3 sage test this?

comment:5 in reply to:  3 Changed 4 years ago by Dima Pasechnik

Replying to gh-timokau:

should we also do the downgrade to optional here?

You mean downgrading the spkg to optional? Is that actually possible already?

Sorry, no, not yet. I forgot about #25837.

comment:6 in reply to:  4 Changed 4 years ago by Frédéric Chapoton

Replying to dimpase:

Could someone with python3 sage test this?

There is no need to test with python3: I know that launching sagenb will fail when trying to import "email" module. I would say that py3-compatibility of sagenb has never been closer, but there is still work, and no worker to handle the task..

comment:7 Changed 4 years ago by Dima Pasechnik

Status: needs_reviewneeds_work

I'm adding docs, please stand by...

comment:8 Changed 4 years ago by François Bissey

Cc: François Bissey added

comment:9 Changed 4 years ago by Dima Pasechnik

Description: modified (diff)
Status: needs_workneeds_review
Summary: sagenb 1.0.4sagenb 1.1.0

comment:10 Changed 4 years ago by Dima Pasechnik

Branch: u/dimpase/packages/sagenb110
Commit: 0f1fbf24fc301dc0afb7a0ce76b053c3b502ca2e

New commits:

7adac2cupdate sagenb to version 1.0.4
059de77trac 25382: remove the sagenb docs from the reference manual.
591e91atrac 25382 remove remaining crosslinks
e2ff902Merge branch 'public/25382' of trac.sagemath.org:sage into nb104
80beebbUpgrade GDB
6769112updated SPKG.txt to note the need for makeinfo
17ab2ceMerge branch 'public/packages/optional/gdb82' of trac.sagemath.org:sage into nb104
0f1fbf2added docs of sagenb

comment:11 Changed 4 years ago by Dima Pasechnik

Dependencies: #24692, #25382

comment:12 Changed 4 years ago by Dima Pasechnik

admittedly, docs are packed with few short autogenerated .rst files; if anyone is willing to tell me how to use sphinx to generate these, be my guest, I can fix this then.

comment:13 Changed 4 years ago by François Bissey

I presume sagenb should now also depend on sphinx, there may be transitive dependency from something else but it is not visible.

comment:14 Changed 4 years ago by git

Commit: 0f1fbf24fc301dc0afb7a0ce76b053c3b502ca2e20b09806a536f6e6a585b9d226c38af58d24b216

Branch pushed to git repo; I updated commit sha1. New commits:

20b0980sphinx must be a dependency

comment:15 in reply to:  13 Changed 4 years ago by Dima Pasechnik

Milestone: sage-8.4sage-8.5

Replying to fbissey:

I presume sagenb should now also depend on sphinx, there may be transitive dependency from something else but it is not visible.

Indeed. Thanks for pointing this out. Fixed in the last commit.

comment:16 Changed 4 years ago by François Bissey

Do we go ahead with this or are we waiting for further changes?

comment:17 Changed 4 years ago by Dima Pasechnik

Well, I am waiting for a review on this ticket... :-)

comment:18 Changed 4 years ago by François Bissey

Reviewers: François Bissey
Status: needs_reviewpositive_review

Looks good to me then :)

comment:19 Changed 4 years ago by Volker Braun

Branch: u/dimpase/packages/sagenb11020b09806a536f6e6a585b9d226c38af58d24b216
Resolution: fixed
Status: positive_reviewclosed

comment:20 Changed 4 years ago by Jeroen Demeyer

Commit: 20b09806a536f6e6a585b9d226c38af58d24b216

How was the "source tarball" ​https://github.com/sagemath/sagenb/releases/download/1.1.0/sagenb-1.1.0.tar.bz2 created? It doesn't correspond with the github repo. In particular, the repo does not contain a bundled mathjax (as it should be), while the "source tarball" does.

Please comment at #26641.

comment:21 Changed 4 years ago by Jeroen Demeyer

I assume that the "source tarball" from this ticket was created from a non-clean checkout of the sagenb repo. I'll fix that on #26641.

comment:22 Changed 4 years ago by Dima Pasechnik

It has been created using the standard procedure as explained in sagenb hacking docs and uploaded to GitHub.

Naturally it is not quite the same as what you have in GitHub report.

Note: See TracTickets for help on using tickets.