Opened 4 years ago
Closed 3 years ago
#26495 closed enhancement (fixed)
Py3 : Fix doctests in module tests/french_book
Reported by:  vklein  Owned by:  

Priority:  major  Milestone:  sage8.7 
Component:  python3  Keywords:  
Cc:  zimmerma, tscrim  Merged in:  
Authors:  Vincent Klein, Frédéric Chapoton  Reviewers:  Vincent Klein 
Report Upstream:  N/A  Work issues:  
Branch:  2a6aae8 (Commits, GitHub, GitLab)  Commit:  2a6aae804b54637c9584a8e6bf75ddc01fad86a3 
Dependencies:  Stopgaps: 
Description (last modified by )
For frenchbook doctests errors, I chose to use doctest flag # py2
instead of rewriting the examples.
As the tests are supposed to be the examples of the book i think it's more consistent to just skip them in python 3 rather than rewrite them and have examples which differ form the book.
The remaining doctests errors does not depends on this "module".
Change History (18)
comment:1 Changed 4 years ago by
 Branch set to u/vklein/26495
comment:2 Changed 4 years ago by
 Commit set to 57bdc26bc290ac61736a0bfb73a7058f8dcdabe5
 Status changed from new to needs_review
comment:3 Changed 4 years ago by
 Cc zimmerma added
comment:4 Changed 4 years ago by
comment:5 Changed 4 years ago by
 Dependencies set to #23572
 Status changed from needs_review to needs_info
comment:6 Changed 4 years ago by
 Status changed from needs_info to needs_work
I will update this ticket after #23572's merge.
comment:7 Changed 4 years ago by
 Milestone changed from sage8.4 to sage8.5
comment:8 Changed 3 years ago by
 Milestone changed from sage8.5 to sage8.7
comment:9 Changed 3 years ago by
the newfrenchbook doctests have many errors ; some may be fixed by #26792
comment:10 Changed 3 years ago by
 Branch changed from u/vklein/26495 to public/ticket/26495
 Commit changed from 57bdc26bc290ac61736a0bfb73a7058f8dcdabe5 to ddef784e73dceb70b607cc71aa8d16c033d3e19f
 Dependencies #23572 deleted
comment:11 Changed 3 years ago by
 Commit changed from ddef784e73dceb70b607cc71aa8d16c033d3e19f to 5db080fcc808b8926515569a36494c0138407a60
Branch pushed to git repo; I updated commit sha1. New commits:
5db080f  py3: some fixes in the book

comment:12 Changed 3 years ago by
 Commit changed from 5db080fcc808b8926515569a36494c0138407a60 to a1e8b4fc2bca5dc674908b1794991e52f52068d0
Branch pushed to git repo; I updated commit sha1. New commits:
a1e8b4f  py3: more fixes in book doctests

comment:13 Changed 3 years ago by
 Commit changed from a1e8b4fc2bca5dc674908b1794991e52f52068d0 to 2a6aae804b54637c9584a8e6bf75ddc01fad86a3
Branch pushed to git repo; I updated commit sha1. New commits:
2a6aae8  trac 26495 fix doctest

comment:14 Changed 3 years ago by
 Status changed from needs_work to needs_review
comment:15 Changed 3 years ago by
 Cc tscrim added
 Description modified (diff)
I suggest that we should positivereview this one and keep other failures for another ticket. See also #26792
comment:16 Changed 3 years ago by
 Reviewers set to Vincent Klein
Ok. Looks good to me. I give positive review to the last three commits.
Frederic you set this ticket in positive review if you validate commit 57bdc26
comment:18 Changed 3 years ago by
 Branch changed from public/ticket/26495 to 2a6aae804b54637c9584a8e6bf75ddc01fad86a3
 Resolution set to fixed
 Status changed from positive_review to closed
New commits:
Trac #26495: Py3 use doctest flag `#py 2` for incompati ...