Opened 4 years ago
Closed 4 years ago
#26485 closed enhancement (fixed)
clean genus.pyx
Reported by: | dcoudert | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-8.5 |
Component: | graph theory | Keywords: | |
Cc: | tscrim, chapoton | Merged in: | |
Authors: | David Coudert | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | c1326aa (Commits, GitHub, GitLab) | Commit: | c1326aa0d9d0792506090b512c761354f644b38f |
Dependencies: | Stopgaps: |
Description
PEP8 cleaning and use of MemoryAllocator
.
Change History (5)
comment:1 Changed 4 years ago by
Branch: | → public/26485_genus_pyx |
---|---|
Cc: | tscrim chapoton added |
Commit: | → 3ba4a14148d099cadd9e06f4f7d7e574289c217a |
Status: | new → needs_review |
comment:2 Changed 4 years ago by
Commit: | 3ba4a14148d099cadd9e06f4f7d7e574289c217a → c1326aa0d9d0792506090b512c761354f644b38f |
---|
comment:3 Changed 4 years ago by
Milestone: | sage-8.4 → sage-8.5 |
---|
Fix a small issue with documentation.
comment:4 Changed 4 years ago by
Reviewers: | → Travis Scrimshaw |
---|---|
Status: | needs_review → positive_review |
I am not fully convinced of replacing memory calls with the MemoryAllocator
object, but there should not be much (any?) harm (possibly an unnoticeable slight slowdown on some things. Anyways, food for thought. LGTM.
comment:5 Changed 4 years ago by
Branch: | public/26485_genus_pyx → c1326aa0d9d0792506090b512c761354f644b38f |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
Sorry to bother you with so many tickets, but the graph module needs a serious cleaning. The hard parts are still to come...
New commits:
clean genus and use MemoryAllocator