Opened 2 years ago

Closed 2 years ago

#26485 closed enhancement (fixed)

clean genus.pyx

Reported by: dcoudert Owned by:
Priority: major Milestone: sage-8.5
Component: graph theory Keywords:
Cc: tscrim, chapoton Merged in:
Authors: David Coudert Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: c1326aa (Commits, GitHub, GitLab) Commit: c1326aa0d9d0792506090b512c761354f644b38f
Dependencies: Stopgaps:

Status badges

Description

PEP8 cleaning and use of MemoryAllocator.

Change History (5)

comment:1 Changed 2 years ago by dcoudert

  • Branch set to public/26485_genus_pyx
  • Cc tscrim chapoton added
  • Commit set to 3ba4a14148d099cadd9e06f4f7d7e574289c217a
  • Status changed from new to needs_review

Sorry to bother you with so many tickets, but the graph module needs a serious cleaning. The hard parts are still to come...

New commits:

​3ba4a14clean genus and use MemoryAllocator

comment:2 Changed 2 years ago by git

  • Commit changed from 3ba4a14148d099cadd9e06f4f7d7e574289c217a to c1326aa0d9d0792506090b512c761354f644b38f

Branch pushed to git repo; I updated commit sha1. New commits:

​abfc07dtrac #: Merged with 8.4
​c1326aatrac #26485: fix minor issue with doctest continuation

comment:3 Changed 2 years ago by dcoudert

  • Milestone changed from sage-8.4 to sage-8.5

Fix a small issue with documentation.

comment:4 Changed 2 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

I am not fully convinced of replacing memory calls with the MemoryAllocator object, but there should not be much (any?) harm (possibly an unnoticeable slight slowdown on some things. Anyways, food for thought. LGTM.

comment:5 Changed 2 years ago by vbraun

  • Branch changed from public/26485_genus_pyx to c1326aa0d9d0792506090b512c761354f644b38f
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.